r110507 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r110506‎ \| r110507 \| r110508 >
Date:	18:14, 1 February 2012
Author:	gregchiasson
Status:	ok
Tags:	aft
Comment:	AFT5: Immediately bail if no param is given. Fixes ugly error when going to '.../Special:ArticleFeedbackv5/'
Modified paths:	/trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
—	—	@@ -74,6 +74,11 @@
75	75	// set robot policy
76	76	$out->setIndexPolicy('noindex');
77	77
	78	+ if( !$param ) {
	79	+ $out->addWikiMsg( 'articlefeedbackv5-invalid-page-id' );
	80	+ return;
	81	+ }
	82	+
78	83	if( preg_match('/^(.+)\/(\d+)$/', $param, $m ) ) {
79	84	$param = $m[1];
80	85	}

01:28, 13 June 2012 Krinkle (talk | contribs) changed the tags for r110507 [removed: nodeploy]
19:17, 1 February 2012 Catrope (talk | contribs) changed the status of r110507 [removed: new added: ok]
18:35, 1 February 2012 MarkAHershberger (talk | contribs) changed the tags for r110507 [added: aft,nodeploy]