r110011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110010‎ | r110011 | r110012 >
Date:18:31, 25 January 2012
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Add FIXME comment about wfSpamBlacklistObject(), see r108778 CR
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
——@@ -238,7 +238,7 @@
239239
240240 // Check SpamBlacklist, if installed
241241 if ( function_exists( 'wfSpamBlacklistObject' ) ) {
242 - $spam = wfSpamBlacklistObject();
 242+ $spam = wfSpamBlacklistObject(); // FIXME: this function exists in the 1.18wmf1 version of SpamBlacklist, but not in the trunk version
243243 $ret = $spam->filter( $title, $value, '' );
244244 if ( $ret !== false ) {
245245 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r110061Followup to r110011 -- SpamBlacklist check now works with both 1.18wmf1 and t...rsterbin15:31, 26 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108778Added spam and abuse filtering:...rsterbin23:16, 12 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   18:38, 25 January 2012

In trunk the function is BaseBlacklist::getInstance( 'spam' );, however I should probably add the old function for backwards compatibility.

Status & tagging log