r110061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110060‎ | r110061 | r110062 >
Date:15:31, 26 January 2012
Author:rsterbin
Status:ok (Comments)
Tags:
Comment:
Followup to r110011 -- SpamBlacklist check now works with both 1.18wmf1 and the trunk version
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
@@ -240,7 +240,11 @@
241241
242242 // Check SpamBlacklist, if installed
243243 if ( function_exists( 'wfSpamBlacklistObject' ) ) {
244 - $spam = wfSpamBlacklistObject(); // FIXME: this function exists in the 1.18wmf1 version of SpamBlacklist, but not in the trunk version
 244+ $spam = wfSpamBlacklistObject();
 245+ } elseif ( class_exists( 'BaseBlacklist' ) ) {
 246+ $spam = BaseBlacklist::getInstance( 'spam' );
 247+ }
 248+ if ( $spam ) {
245249 $ret = $spam->filter( $title, $value, '' );
246250 if ( $ret !== false ) {
247251 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110011Add FIXME comment about wfSpamBlacklistObject(), see r108778 CRcatrope18:31, 25 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   22:28, 26 January 2012

Awesome.

Status & tagging log