r110010 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110009‎ | r110010 | r110011 >
Date:18:26, 25 January 2012
Author:bsitu
Status:ok
Tags:
Comment:
Revert from 107187 to 107186 for bug24430 patch, it causes layout issue
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2240,6 +2240,7 @@
22412241 $attribs = $customAttribs + array(
22422242 'accesskey' => ',',
22432243 'id' => $name,
 2244+ 'cols' => $wgUser->getIntOption( 'cols' ),
22442245 'rows' => $wgUser->getIntOption( 'rows' ),
22452246 'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
22462247 );
Index: trunk/phase3/includes/OutputPage.php
@@ -2248,6 +2248,7 @@
22492249 $params = array(
22502250 'id' => 'wpTextbox1',
22512251 'name' => 'wpTextbox1',
 2252+ 'cols' => $this->getUser()->getOption( 'cols' ),
22522253 'rows' => $this->getUser()->getOption( 'rows' ),
22532254 'readonly' => 'readonly',
22542255 'lang' => $pageLang->getHtmlCode(),
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3192,6 +3192,7 @@
31933193 */
31943194 $wgDefaultUserOptions = array(
31953195 'ccmeonemails' => 0,
 3196+ 'cols' => 80,
31963197 'date' => 'default',
31973198 'diffonly' => 0,
31983199 'disablemail' => 0,
Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -847,6 +847,7 @@
848848 $out->addHTML(
849849 Xml::element( 'textarea', array(
850850 'readonly' => 'readonly',
 851+ 'cols' => intval( $user->getOption( 'cols' ) ),
851852 'rows' => intval( $user->getOption( 'rows' ) ) ),
852853 $rev->getText( Revision::FOR_THIS_USER, $user ) . "\n" ) .
853854 Xml::openElement( 'div' ) .
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -962,6 +962,7 @@
963963 ? 'filereuploadsummary'
964964 : 'fileuploadsummary',
965965 'default' => $this->mComment,
 966+ 'cols' => intval( $this->getUser()->getOption( 'cols' ) ),
966967 'rows' => 8,
967968 )
968969 );
Index: trunk/phase3/includes/Preferences.php
@@ -29,6 +29,7 @@
3030 static $defaultPreferences = null;
3131 static $saveFilters = array(
3232 'timecorrection' => array( 'Preferences', 'filterTimezoneInput' ),
 33+ 'cols' => array( 'Preferences', 'filterIntval' ),
3334 'rows' => array( 'Preferences', 'filterIntval' ),
3435 'rclimit' => array( 'Preferences', 'filterIntval' ),
3536 'wllimit' => array( 'Preferences', 'filterIntval' ),
@@ -688,7 +689,13 @@
689690 global $wgUseExternalEditor, $wgAllowUserCssPrefs;
690691
691692 ## Editing #####################################
692 -
 693+ $defaultPreferences['cols'] = array(
 694+ 'type' => 'int',
 695+ 'label-message' => 'columns',
 696+ 'section' => 'editing/textboxsize',
 697+ 'min' => 4,
 698+ 'max' => 1000,
 699+ );
693700 $defaultPreferences['rows'] = array(
694701 'type' => 'int',
695702 'label-message' => 'rows',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107187bug24430 - patch from Chinchin, remove number of column for edit field in pre...bsitu22:47, 23 December 2011
r108870followup to -r107187 - adding bug24430 patch to 1.19 release notebsitu22:58, 13 January 2012
r110007Revert from 109557 to 109556 for bug24430 patch, it causes layout issuebsitu18:05, 25 January 2012
r110008Revert from 108870 to 108869 since bug24430 patch got revertedbsitu18:17, 25 January 2012
r110009Revert from 107188 to 107187 for bug24430 patch, it causes layout issuebsitu18:22, 25 January 2012

Status & tagging log