r108682 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108681‎ | r108682 | r108683 >
Date:21:52, 11 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 33117) prop=revisions allows deleted text to be exposed through cache pollution
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
——@@ -131,7 +131,7 @@
132132 if ( !$difftoRev ) {
133133 $this->dieUsageMsg( array( 'nosuchrevid', $params['diffto'] ) );
134134 }
135 - if ( !$difftoRev->userCan( Revision::DELETED_TEXT ) ) {
 135+ if ( $difftoRev->isDeleted( Revision::DELETED_TEXT ) ) {
136136 $this->setWarning( "Couldn't diff to r{$difftoRev->getID()}: content is hidden" );
137137 $params['diffto'] = null;
138138 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r108683* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:52, 11 January 2012
r108686* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:58, 11 January 2012
r108687* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:59, 11 January 2012

Comments

#Comment by Duplicatebug (talk | contribs)   18:01, 14 January 2012

Instead of a warning, it also better to add that tag with a diffhidden="" or so (like the other texthidden, userhidden and commenthidden). Yes, it was not so before, but only as idea and only for the next release.

Status & tagging log