r108681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108680‎ | r108681 | r108682 >
Date:21:31, 11 January 2012
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
follow-up to r108110 - re-adding needed global var; also fixing fatal error on construct
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNoticePageLogPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNoticePageLogPager.php
@@ -15,7 +15,7 @@
1616 */
1717 function __construct( $special, $type = 'bannercontent' ) {
1818 $this->special = $special;
19 - parent::__construct( $special );
 19+ parent::__construct();
2020
2121 $this->viewPage = SpecialPage::getTitleFor( 'NoticeTemplate', 'view' );
2222 $this->logType = $type;
@@ -59,6 +59,7 @@
6060 * Generate the content of each table row (1 row = 1 log entry)
6161 */
6262 function formatRow( $row ) {
 63+ global $wgLang;
6364 // Create a user object so we can pull the name, user page, etc.
6465 $loggedUser = User::newFromId( $row->rc_user );
6566 // Create the user page link

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108110Update deprecated code...reedy01:48, 5 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   01:13, 12 January 2012

Instead of removing the parameter you should of gotten the context from the special page and passed that.

Status & tagging log