r108683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108682‎ | r108683 | r108684 >
Date:21:52, 11 January 2012
Author:reedy
Status:ok
Tags:
Comment:
* (bug 33117) prop=revisions allows deleted text to be exposed through cache pollution
Modified paths:
  • /branches/wmf/1.18wmf1/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/api/ApiQueryRevisions.php
@@ -136,7 +136,7 @@
137137 if ( !$difftoRev ) {
138138 $this->dieUsageMsg( array( 'nosuchrevid', $params['diffto'] ) );
139139 }
140 - if ( !$difftoRev->userCan( Revision::DELETED_TEXT ) ) {
 140+ if ( $difftoRev->isDeleted( Revision::DELETED_TEXT ) ) {
141141 $this->setWarning( "Couldn't diff to r{$difftoRev->getID()}: content is hidden" );
142142 $params['diffto'] = null;
143143 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r108686* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:58, 11 January 2012
r108687* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:59, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108682* (bug 33117) prop=revisions allows deleted text to be exposed through cache ...reedy21:52, 11 January 2012

Status & tagging log