r108680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108679‎ | r108680 | r108681 >
Date:20:56, 11 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ShortUrl (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ShortUrl/ShortUrl.hooks.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ShortUrl/ShortUrl.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ShortUrl/ShortUrl.php
@@ -19,10 +19,10 @@
2020 * Configuration variables
2121 * Prefix to use for the shortened URL. mod_rewrite (or equivalent) needs to be setup
2222 * to produce a shorter URL
23 - * Default is 'null' which just uses the (not so short) URL that all Special Pages get
 23+ * Default is false which just uses the (not so short) URL that all Special Pages get
2424 * Eg: http://en.wikipedia.org/wiki/Special:ShortUrl/5234
2525 */
26 -$wgShortUrlPrefix = null;
 26+$wgShortUrlPrefix = false;
2727
2828 // Extension credits that will show up on Special:Version
2929 $wgExtensionCredits['specialpage'][] = array(
Index: branches/wmf/1.18wmf1/extensions/ShortUrl/ShortUrl.hooks.php
@@ -21,7 +21,7 @@
2222 public static function addToolboxLink( &$tpl ) {
2323 global $wgOut, $wgShortUrlPrefix;
2424
25 - if ( $wgShortUrlPrefix === null ) {
 25+ if ( !is_string( $wgShortUrlPrefix ) ) {
2626 $urlPrefix = SpecialPage::getTitleFor( 'ShortUrl' )->getCanonicalUrl() . '/';
2727 } else {
2828 $urlPrefix = $wgShortUrlPrefix;
Property changes on: branches/wmf/1.18wmf1/extensions/ShortUrl
___________________________________________________________________
Added: svn:mergeinfo
2929 Merged /branches/REL1_15/phase3/extensions/ShortUrl:r51646
3030 Merged /branches/REL1_18/extensions/ShortUrl:r101758,103190
3131 Merged /branches/REL1_17/phase3/extensions/ShortUrl:r81445,81448
3232 Merged /trunk/extensions/ShortUrl:r95614,99592,99653,100092,100419,100516,100686,100692,100699,103260,103315,103378,103382,103669,104337,104736,104862-104863,104865,104971,105275,105902,105908,107043,107050,107337,107783,107816,107818,108679
3333 Merged /branches/sqlite/extensions/ShortUrl:r58211-58321
3434 Merged /trunk/phase3/extensions/ShortUrl:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93520,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94995-94997,95023,95042,95072-95073,95155,95327,95332,95410,95422,95426,95442,95468,95601,95812,98578,98598,98656
3535 Merged /branches/new-installer/phase3/extensions/ShortUrl:r43664-66004

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108679Default wgShortUrlPrefix to false...reedy20:52, 11 January 2012

Status & tagging log