r108562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108561‎ | r108562 | r108563 >
Date:23:36, 10 January 2012
Author:siebrand
Status:reverted (Comments)
Tags:
Comment:
(bug 33645) Translate popups don't deal with markup in summary field description.
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationEditPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationEditPage.php
@@ -111,7 +111,9 @@
112112 $hidden[] = Html::hidden( 'format', 'json' );
113113 $hidden[] = Html::hidden( 'action', 'edit' );
114114
115 - $summary = Xml::inputLabel( wfMsg( 'summary' ), 'summary', 'summary', 40 );
 115+ // Allow links and "sup" in MediaWiki:Summary to work here, so do not use Xml::inputLabel().
 116+ $summary = Html::rawElement( 'label', array( 'for' => 'summary' ), wfMessage( 'summary' )->text() );
 117+ $summaryInput = Xml::input( 'summary', 40, false, array( 'id' => 'summary' ) );
116118 $save = Xml::submitButton( wfMsg( 'savearticle' ), array( 'class' => 'mw-translate-save' ) );
117119 $saveAndNext = Xml::submitButton( wfMsg( 'translate-js-next' ), array( 'class' => 'mw-translate-next' ) );
118120 $skip = Html::element( 'input', array( 'class' => 'mw-translate-skip', 'type' => 'button', 'value' => wfMsg( 'translate-js-skip' ) ) );
@@ -132,7 +134,7 @@
133135 $support = $this->getSupportButton( $this->getTitle() );
134136
135137 if ( $wgUser->isAllowed( 'translate' ) ) {
136 - $bottom = "$summary$save$saveAndNext$skip$history$support";
 138+ $bottom = "$summary$summaryInput$save$saveAndNext$skip$history$support";
137139 } else {
138140 $text = wfMessage( 'translate-edit-nopermission' )->escaped();
139141 $button = $this->getPermissionPageButton();

Follow-up revisions

RevisionCommit summaryAuthorDate
r108606Revert r108562 - going to introduce new message in next commitnikerabbit10:02, 11 January 2012
r108608Don't reuse messages from core, causes problems with wikitext/html customisat...nikerabbit10:07, 11 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:43, 11 January 2012

I think we should just not reuse this message. I'm also against adding new raw html messages.

#Comment by Siebrand (talk | contribs)   07:51, 11 January 2012

Okay. Can you revert and add a new key?

#Comment by Nikerabbit (talk | contribs)   08:18, 11 January 2012

Yes today.

Status & tagging log