r108606 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108605‎ | r108606 | r108607 >
Date:10:02, 11 January 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Revert r108562 - going to introduce new message in next commit
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationEditPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationEditPage.php
@@ -111,9 +111,7 @@
112112 $hidden[] = Html::hidden( 'format', 'json' );
113113 $hidden[] = Html::hidden( 'action', 'edit' );
114114
115 - // Allow links and "sup" in MediaWiki:Summary to work here, so do not use Xml::inputLabel().
116 - $summary = Html::rawElement( 'label', array( 'for' => 'summary' ), wfMessage( 'summary' )->text() );
117 - $summaryInput = Xml::input( 'summary', 40, false, array( 'id' => 'summary' ) );
 115+ $summary = Xml::inputLabel( wfMsg( 'summary' ), 'summary', 'summary', 40 );
118116 $save = Xml::submitButton( wfMsg( 'savearticle' ), array( 'class' => 'mw-translate-save' ) );
119117 $saveAndNext = Xml::submitButton( wfMsg( 'translate-js-next' ), array( 'class' => 'mw-translate-next' ) );
120118 $skip = Html::element( 'input', array( 'class' => 'mw-translate-skip', 'type' => 'button', 'value' => wfMsg( 'translate-js-skip' ) ) );
@@ -134,7 +132,7 @@
135133 $support = $this->getSupportButton( $this->getTitle() );
136134
137135 if ( $wgUser->isAllowed( 'translate' ) ) {
138 - $bottom = "$summary$summaryInput$save$saveAndNext$skip$history$support";
 136+ $bottom = "$summary$save$saveAndNext$skip$history$support";
139137 } else {
140138 $text = wfMessage( 'translate-edit-nopermission' )->escaped();
141139 $button = $this->getPermissionPageButton();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108562(bug 33645) Translate popups don't deal with markup in summary field descript...siebrand23:36, 10 January 2012

Status & tagging log