r108608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108607‎ | r108608 | r108609 >
Date:10:07, 11 January 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Don't reuse messages from core, causes problems with wikitext/html customisations.
Ping bug 33645, r108562
Modified paths:
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)
  • /trunk/extensions/Translate/utils/TranslationEditPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationEditPage.php
@@ -111,8 +111,8 @@
112112 $hidden[] = Html::hidden( 'format', 'json' );
113113 $hidden[] = Html::hidden( 'action', 'edit' );
114114
115 - $summary = Xml::inputLabel( wfMsg( 'summary' ), 'summary', 'summary', 40 );
116 - $save = Xml::submitButton( wfMsg( 'savearticle' ), array( 'class' => 'mw-translate-save' ) );
 115+ $summary = Xml::inputLabel( wfMsg( 'translate-js-summary' ), 'summary', 'summary', 40 );
 116+ $save = Xml::submitButton( wfMsg( 'translate-js-save' ), array( 'class' => 'mw-translate-save' ) );
117117 $saveAndNext = Xml::submitButton( wfMsg( 'translate-js-next' ), array( 'class' => 'mw-translate-next' ) );
118118 $skip = Html::element( 'input', array( 'class' => 'mw-translate-skip', 'type' => 'button', 'value' => wfMsg( 'translate-js-skip' ) ) );
119119
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -344,6 +344,8 @@
345345 Make sure your editor does not remove msgctxt fields.
346346 Details: $1',
347347
 348+ 'translate-js-summary' => 'Summary:',
 349+ 'translate-js-save' => 'Save',
348350 'translate-js-next' => 'Save and open next',
349351 'translate-js-nonext' => 'This was the last message on this page.',
350352 'translate-js-skip' => 'Skip to next',
@@ -627,6 +629,8 @@
628630 'translate-import-err-no-such-file' => 'Used in [[Special:ImportTranslations]].',
629631 'translate-import-err-no-headers' => 'Used in [[Special:ImportTranslations]].',
630632 'translate-import-err-warnings' => 'Used in [[Special:ImportTranslations]].',
 633+ 'translate-js-summary' => 'Label for summary field in translation editor',
 634+ 'translate-js-save' => 'Button in translation editor which saves the content and closes the dialog',
631635 'translate-js-next' => 'next refers to next message in the message list',
632636 'translate-js-nonext' => 'This is a JavaScript popup (alert) when user clicks "Save and open next" and there is no next message.',
633637 'translate-js-skip' => 'A button together with Save and Save an open next. Goes to the next message without saving.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r109052MFT r108608 r108660 r108792 r108815 r108816nikerabbit18:40, 16 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108562(bug 33645) Translate popups don't deal with markup in summary field descript...siebrand23:36, 10 January 2012

Status & tagging log