r108043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108042‎ | r108043 | r108044 >
Date:15:40, 4 January 2012
Author:rsterbin
Status:ok
Tags:aft 
Comment:
AFTv5 debug now follows ResourceLoader debug if the config setting is off
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -59,7 +59,7 @@
6060 /**
6161 * Are we in debug mode?
6262 */
63 - $.articleFeedbackv5.debug = mw.config.get( 'wgArticleFeedbackv5Debug' ) ? true : false;
 63+ $.articleFeedbackv5.debug = mw.config.get( 'wgArticleFeedbackv5Debug' ) ? true : ( mw.util.getParamValue( 'debug' ) ? true : false );
6464
6565 /**
6666 * Are we tracking clicks?
@@ -2015,8 +2015,6 @@
20162016 $.articleFeedbackv5.clickTracking = $.articleFeedbackv5.checkClickTracking();
20172017 // Has the user already submitted ratings for this page at this revision?
20182018 $.articleFeedbackv5.alreadySubmitted = $.cookie( $.articleFeedbackv5.prefix( 'submitted' ) ) === 'true';
2019 - // Are we in debug mode?
2020 - $.articleFeedbackv5.debug = mw.config.get( 'wgArticleFeedbackv5Debug' ) ? true : false;
20212019 // Go ahead and bucket right away
20222020 $.articleFeedbackv5.selectBucket();
20232021 // Anything the bucket needs to do?

Status & tagging log