r107835 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107834‎ | r107835 | r107836 >
Date:15:31, 2 January 2012
Author:demon
Status:reverted (Comments)
Tags:
Comment:
simplify r107833 per CR, just use wfExpandUrl()
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -192,9 +192,7 @@
193193 $wgForeignFileRepos[] = array(
194194 'class' => 'ForeignAPIRepo',
195195 'name' => 'wikimediacommons',
196 - 'apibase' => WebRequest::detectProtocol() === 'https' ?
197 - 'https://commons.wikimedia.org/w/api.php' :
198 - 'http://commons.wikimedia.org/w/api.php',
 196+ 'apibase' => wfExpandUrl( '//commons.wikimedia.org/w/api.php' ),
199197 'hashLevels' => 2,
200198 'fetchDescription' => true,
201199 'descriptionCacheExpiry' => 43200,

Follow-up revisions

RevisionCommit summaryAuthorDate
r107846Revert r107835 - breaks my wiki "unknown function'nikerabbit18:26, 2 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107833Revert r107042 (bug 32219, make InstantCommons protocol-relative) and do it p...demon14:38, 2 January 2012

Comments

#Comment by Platonides (talk | contribs)   14:41, 7 January 2012

You can't use wfExpandUrl in line 195 when GlobalFunctions is not required until line 373.

Status & tagging log