r107846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107845‎ | r107846 | r107847 >
Date:18:26, 2 January 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Revert r107835 - breaks my wiki "unknown function'
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -192,7 +192,9 @@
193193 $wgForeignFileRepos[] = array(
194194 'class' => 'ForeignAPIRepo',
195195 'name' => 'wikimediacommons',
196 - 'apibase' => wfExpandUrl( '//commons.wikimedia.org/w/api.php' ),
 196+ 'apibase' => WebRequest::detectProtocol() === 'https' ?
 197+ 'https://commons.wikimedia.org/w/api.php' :
 198+ 'http://commons.wikimedia.org/w/api.php',
197199 'hashLevels' => 2,
198200 'fetchDescription' => true,
199201 'descriptionCacheExpiry' => 43200,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107835simplify r107833 per CR, just use wfExpandUrl()demon15:31, 2 January 2012

Status & tagging log