r107042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107041‎ | r107042 | r107043 >
Date:08:33, 22 December 2011
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Make apibase of $wgForeignFileRepos (InstantCommons) protocol relative too
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
——@@ -192,7 +192,7 @@
193193 $wgForeignFileRepos[] = array(
194194 'class' => 'ForeignAPIRepo',
195195 'name' => 'wikimediacommons',
196 - 'apibase' => 'http://commons.wikimedia.org/w/api.php',
 196+ 'apibase' => '//commons.wikimedia.org/w/api.php',
197197 'hashLevels' => 2,
198198 'fetchDescription' => true,
199199 'descriptionCacheExpiry' => 43200,

Sign-offs

UserFlagDate
Nikerabbitinspected11:12, 22 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r107833Revert r107042 (bug 32219, make InstantCommons protocol-relative) and do it p...demon14:38, 2 January 2012

Comments

#Comment by Moejoe000 (talk | contribs)   11:20, 22 December 2011

AFIAK, this is used by MediaWiki itself (phase3/includes/filerepo/ForeignAPIRepo.php) to fetch data from commons. Does this make any sense to be here protocol-relative?

#Comment by Duplicatebug (talk | contribs)   19:06, 22 December 2011

See bug 32219

Status & tagging log