r107446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107445‎ | r107446 | r107447 >
Date:22:38, 27 December 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Comment and whitespace fixes
Modified paths:
  • /trunk/phase3/includes/cache/FileCacheBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/FileCacheBase.php
@@ -33,7 +33,7 @@
3434 }
3535
3636 /**
37 - * Get the base cache directory (not speficic to this file)
 37+ * Get the base cache directory (not specific to this file)
3838 * @return string
3939 */
4040 abstract protected function cacheDirectory();
@@ -98,7 +98,7 @@
9999
100100 $cachetime = $this->cacheTimestamp();
101101 $good = ( $timestamp <= $cachetime && $wgCacheEpoch <= $cachetime );
102 - wfDebug( __METHOD__ . ": cachetime $cachetime, touched '{$timestamp}' epoch {$wgCacheEpoch}, good $good\n");
 102+ wfDebug( __METHOD__ . ": cachetime $cachetime, touched '{$timestamp}' epoch {$wgCacheEpoch}, good $good\n" );
103103
104104 return $good;
105105 }
@@ -203,8 +203,8 @@
204204 public function incrMissesRecent( WebRequest $request ) {
205205 global $wgMemc;
206206 if ( mt_rand( 0, self::MISS_FACTOR - 1 ) == 0 ) {
207 - # Get an large IP range that should include the user
208 - # even if that person's IP address changes...
 207+ # Get a large IP range that should include the user even if that
 208+ # person's IP address changes
209209 $ip = $request->getIP();
210210 if ( !IP::isValid( $ip ) ) {
211211 return;

Comments

#Comment by Aaron Schulz (talk | contribs)   02:18, 28 December 2011

'include the user even' ?

#Comment by Tim Starling (talk | contribs)   02:44, 28 December 2011

Are you saying there should be a comma?

#Comment by Aaron Schulz (talk | contribs)   02:51, 28 December 2011

There are two spaces between 'user' and 'even'. Though it doesn't show in CR comments I guess :)

#Comment by Tim Starling (talk | contribs)   04:49, 28 December 2011

That seems like a very trivial nitpick for someone who can't spell specific ;)

Status & tagging log