r107445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107444‎ | r107445 | r107446 >
Date:22:17, 27 December 2011
Author:laner
Status:ok
Tags:
Comment:
Actually delete the domain. Follow up to r107443.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaDomain.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaDomain.php
@@ -283,7 +283,8 @@
284284 $wgAuth->printDebug( "Failed to delete domain $domainname, since it had sub entries", NONSENSITIVE );
285285 return false;
286286 }
287 - // FIXME: $success is undefined
 287+
 288+ $success = LdapAuthenticationPlugin::ldap_delete( $wgAuth->ldapconn, $dn );
288289 if ( $success ) {
289290 $wgAuth->printDebug( "Successfully deleted domain $domainname", NONSENSITIVE );
290291 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107443Add FIXME comment to OpenStackNovaDomain...reedy22:13, 27 December 2011

Status & tagging log