r107447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107446‎ | r107447 | r107448 >
Date:22:39, 27 December 2011
Author:mah
Status:resolved
Tags:
Comment:
re Aaron's comment on r107351: remove double extension from temporary file
Modified paths:
  • /trunk/phase3/includes/filerepo/file/File.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/File.php
@@ -782,7 +782,7 @@
783783 $extension = $this->getExtension();
784784 list( $thumbExt, $thumbMime ) = $this->handler->getThumbType(
785785 $extension, $this->getMimeType(), $params );
786 - $tmpFile = TempFSFile::factory( 'transform_', $this->getExtension() . '.' . $thumbExt );
 786+ $tmpFile = TempFSFile::factory( 'transform_', FileBackend::extensionFromPath( $thumbPath ) );
787787 if ( !$tmpFile ) {
788788 return new MediaTransformError( 'thumbnail_error',
789789 $params['width'], 0, wfMsg( 'thumbnail-temp-create' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r107448* Follow-up r107447: removed dead code...aaron22:49, 27 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107351* First simple XCF thumbnailing. Convert from ImageMagick has buggy...mah00:46, 27 December 2011

Status & tagging log