r107187 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107186‎ | r107187 | r107188 >
Date:22:47, 23 December 2011
Author:bsitu
Status:reverted (Comments)
Tags:
Comment:
bug24430 - patch from Chinchin, remove number of column for edit field in preference
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2100,7 +2100,6 @@
21012101 $attribs = $customAttribs + array(
21022102 'accesskey' => ',',
21032103 'id' => $name,
2104 - 'cols' => $wgUser->getIntOption( 'cols' ),
21052104 'rows' => $wgUser->getIntOption( 'rows' ),
21062105 'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
21072106 );
Index: trunk/phase3/includes/OutputPage.php
@@ -2248,7 +2248,6 @@
22492249 $params = array(
22502250 'id' => 'wpTextbox1',
22512251 'name' => 'wpTextbox1',
2252 - 'cols' => $this->getUser()->getOption( 'cols' ),
22532252 'rows' => $this->getUser()->getOption( 'rows' ),
22542253 'readonly' => 'readonly',
22552254 'lang' => $pageLang->getHtmlCode(),
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3178,7 +3178,6 @@
31793179 */
31803180 $wgDefaultUserOptions = array(
31813181 'ccmeonemails' => 0,
3182 - 'cols' => 80,
31833182 'date' => 'default',
31843183 'diffonly' => 0,
31853184 'disablemail' => 0,
Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -847,7 +847,6 @@
848848 $out->addHTML(
849849 Xml::element( 'textarea', array(
850850 'readonly' => 'readonly',
851 - 'cols' => intval( $user->getOption( 'cols' ) ),
852851 'rows' => intval( $user->getOption( 'rows' ) ) ),
853852 $rev->getText( Revision::FOR_THIS_USER, $user ) . "\n" ) .
854853 Xml::openElement( 'div' ) .
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -956,7 +956,6 @@
957957 ? 'filereuploadsummary'
958958 : 'fileuploadsummary',
959959 'default' => $this->mComment,
960 - 'cols' => intval( $this->getUser()->getOption( 'cols' ) ),
961960 'rows' => 8,
962961 )
963962 );
Index: trunk/phase3/includes/Preferences.php
@@ -29,7 +29,6 @@
3030 static $defaultPreferences = null;
3131 static $saveFilters = array(
3232 'timecorrection' => array( 'Preferences', 'filterTimezoneInput' ),
33 - 'cols' => array( 'Preferences', 'filterIntval' ),
3433 'rows' => array( 'Preferences', 'filterIntval' ),
3534 'rclimit' => array( 'Preferences', 'filterIntval' ),
3635 'wllimit' => array( 'Preferences', 'filterIntval' ),
@@ -689,13 +688,7 @@
690689 global $wgUseExternalEditor, $wgAllowUserCssPrefs;
691690
692691 ## Editing #####################################
693 - $defaultPreferences['cols'] = array(
694 - 'type' => 'int',
695 - 'label-message' => 'columns',
696 - 'section' => 'editing/textboxsize',
697 - 'min' => 4,
698 - 'max' => 1000,
699 - );
 692+
700693 $defaultPreferences['rows'] = array(
701694 'type' => 'int',
702695 'label-message' => 'rows',

Follow-up revisions

RevisionCommit summaryAuthorDate
r107188follow up to -r107187 - remove unused message key "column" from language filebsitu23:55, 23 December 2011
r107192Follow-up r107187, r107188: rebuild MessagesXx.php.siebrand00:13, 24 December 2011
r108870followup to -r107187 - adding bug24430 patch to 1.19 release notebsitu22:58, 13 January 2012
r109557followup to r107187 - Making textarea width to be 100% in all skinsbsitu18:22, 19 January 2012
r110007Revert from 109557 to 109556 for bug24430 patch, it causes layout issuebsitu18:05, 25 January 2012
r110008Revert from 108870 to 108869 since bug24430 patch got revertedbsitu18:17, 25 January 2012
r110009Revert from 107188 to 107187 for bug24430 patch, it causes layout issuebsitu18:22, 25 January 2012
r110010Revert from 107187 to 107186 for bug24430 patch, it causes layout issuebsitu18:26, 25 January 2012

Comments

#Comment by Siebrand (talk | contribs)   23:31, 23 December 2011

I'm pretty sure this removal is incomplete. One or more message keys Will be unused now, and need to be removed from MessagesEn.php and messages.inc.

#Comment by Bsitu (talk | contribs)   23:45, 23 December 2011

nice catch! thank you

#Comment by Krinkle (talk | contribs)   22:47, 13 January 2012

Removing a preference is, although justified, a significant change. Please add release notes!

Status & tagging log