r109557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109556‎ | r109557 | r109558 >
Date:18:22, 19 January 2012
Author:bsitu
Status:reverted (Comments)
Tags:
Comment:
followup to r107187 - Making textarea width to be 100% in all skins
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/cologneblue/screen.css (modified) (history)
  • /trunk/phase3/skins/common/wikistandard.css (modified) (history)
  • /trunk/phase3/skins/nostalgia/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/nostalgia/screen.css
——@@ -41,6 +41,7 @@
4242
4343 textarea {
4444 overflow: auto;
 45+ width: 100%;
4546 }
4647
4748 p.subtitle {
Index: trunk/phase3/skins/chick/main.css
——@@ -35,6 +35,7 @@
3636 color: black;
3737 background-color: white;
3838 overflow: auto;
 39+ width: 100%;
3940 }
4041 /* hide this from ie/mac and konq2.2 */
4142 @media All {
Index: trunk/phase3/skins/common/wikistandard.css
——@@ -88,6 +88,7 @@
8989
9090 textarea {
9191 overflow: auto;
 92+ width: 100%;
9293 }
9394
9495 h1.pagetitle {
Index: trunk/phase3/skins/cologneblue/screen.css
——@@ -58,6 +58,7 @@
5959
6060 textarea {
6161 overflow: auto;
 62+ width: 100%;
6263 }
6364
6465 #footer {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107187bug24430 - patch from Chinchin, remove number of column for edit field in pre...bsitu22:47, 23 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:14, 20 January 2012

Would this be suitable candidate for moving into one of the common* stylesheets?

#Comment by Bsitu (talk | contribs)   17:49, 20 January 2012

Yeah, I was thinking about moving it to shared.css, but I am not sure if this would break any layout

#Comment by Hashar (talk | contribs)   10:14, 23 January 2012

the common* CSS only apply to MonoBook and Vector skins. commonElements.css already has the 100% width applied.

All that stuff is so messy nowadays (we have oldshared.css, shared.css and common*) that I am just marking this ok.

#Comment by Krinkle (talk | contribs)   01:03, 25 January 2012

This is marked as follow-up, but was intended as bugfix for bug 24430 / bug 33780.

I think we should revert this. It doesn't fix the bug and changes default styling in all kinds of places where it may not be expected and breaking layouts.

#Comment by Bsitu (talk | contribs)   01:21, 25 January 2012

Krinkle,

Thanks for checking on this, I am seeing textarea with 100% width in Vector and some other skins so I thought it's okay to apply it to the rest of the skins.

Probably I should revert 107187 as well since it removes 80 cols and implies 20 cols by default

#Comment by Krinkle (talk | contribs)   01:25, 25 January 2012

Yeah, that part of r107187 is a problem. Although perhaps we can fix this inside Html class by forcing a cols=80 default unless given otherwise by the caller?

Status & tagging log