r105964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105963‎ | r105964 | r105965 >
Date:01:14, 13 December 2011
Author:tstarling
Status:ok
Tags:live 
Comment:
Temporary workaround for bug 31576. The logs show that once every hour or so, a job runner somewhere in the cluster somehow loses all its magic words and starts hitting this case. Throwing an exception should kill the job runner before it does too much damage.
Modified paths:
  • /branches/wmf/1.18wmf1/includes/MagicWord.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/MagicWord.php
——@@ -278,8 +278,8 @@
279279 $wgContLang->getMagic( $this );
280280 if ( !$this->mSynonyms ) {
281281 $this->mSynonyms = array( 'dkjsagfjsgashfajsh' );
282 - #throw new MWException( "Error: invalid magic word '$id'" );
283 - wfDebugLog( 'exception', "Error: invalid magic word '$id'\n" );
 282+ throw new MWException( "Error: invalid magic word '$id'" );
 283+ #wfDebugLog( 'exception', "Error: invalid magic word '$id'\n" );
284284 }
285285 wfProfileOut( __METHOD__ );
286286 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1134111.19wmf1: MFT r105964, r106137catrope22:08, 8 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r1040591.18wmf1: Live hacks for investigating bug 31576: add server name to pcache c...catrope18:04, 23 November 2011
r1047011.18wmf1: Another live debugging hack for bug 31576catrope16:57, 30 November 2011
r1047221.18wmf1: Another logging hack for bug 31576catrope19:26, 30 November 2011
r104732Add RefreshLinks class to the AutoLoader, I'll need it for my cleanup script ...catrope20:03, 30 November 2011
r104758Script for cleaning up the mess left behind by bug 31576. Still haven't figur...catrope21:49, 30 November 2011

Status & tagging log