r104722 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104721‎ | r104722 | r104723 >
Date:19:26, 30 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.18wmf1: Another logging hack for bug 31576
Modified paths:
  • /branches/wmf/1.18wmf1/includes/job/RefreshLinksJob.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/job/RefreshLinksJob.php
@@ -115,6 +115,22 @@
116116 $options = new ParserOptions;
117117 $parserOutput = $wgParser->parse( $revision->getText(), $title, $options, true, true, $revision->getId() );
118118 wfProfileOut( __METHOD__.'-parse' );
 119+
 120+ // HACK for debugging bug 31576 --Roan
 121+ $templates = $parserOutput->getTemplates();
 122+ if ( isset( $templates[NS_TEMPLATE] ) ) {
 123+ $badStuff = array_intersect( array( 'NAMESPACE', 'PAGENAME', 'SERVER', 'CONTENTLANGUAGE', 'PAGENAMEE' ), array_keys( $templates[NS_TEMPLATE] ) );
 124+ if ( $badStuff !== array() ) {
 125+ $hostname = wfHostname();
 126+ $wiki = wfWikiID();
 127+ $bad = implode( ', ', $badStuff );
 128+ $parsedPage = $title->getPrefixedText();
 129+ $jobPage = $this->title->getPrefixedText();
 130+ wfErrorLog( "JOB QUEUE bad templates: $bad when parsing [[$parsedPage]] on $wiki by $hostname job for [[$jobPage]]\n", 'udp://10.0.5.8:8420/bug31576jq' );
 131+ }
 132+ }
 133+
 134+
119135 wfProfileIn( __METHOD__.'-update' );
120136 $update = new LinksUpdate( $title, $parserOutput, false );
121137 $update->doUpdate();

Follow-up revisions

RevisionCommit summaryAuthorDate
r104732Add RefreshLinks class to the AutoLoader, I'll need it for my cleanup script ...catrope20:03, 30 November 2011
r104758Script for cleaning up the mess left behind by bug 31576. Still haven't figur...catrope21:49, 30 November 2011
r105964Temporary workaround for bug 31576. The logs show that once every hour or so,...tstarling01:14, 13 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r1040591.18wmf1: Live hacks for investigating bug 31576: add server name to pcache c...catrope18:04, 23 November 2011
r1047011.18wmf1: Another live debugging hack for bug 31576catrope16:57, 30 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   14:53, 24 December 2011

Was the issue found yet?

Status & tagging log