r106137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106136‎ | r106137 | r106138 >
Date:23:51, 13 December 2011
Author:tstarling
Status:ok
Tags:
Comment:
Use the pure PHP version of CDB so that we can get better error handling and logging. Hopefully will shed some light on bug 32170 and related.
Modified paths:
  • /branches/wmf/1.18wmf1/includes/Cdb.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/Cdb.php
@@ -19,12 +19,12 @@
2020 * @return CdbReader
2121 */
2222 public static function open( $fileName ) {
23 - if ( self::haveExtension() ) {
24 - return new CdbReader_DBA( $fileName );
25 - } else {
26 - wfDebug( "Warning: no dba extension found, using emulation.\n" );
 23+ //if ( self::haveExtension() ) {
 24+ // return new CdbReader_DBA( $fileName );
 25+ //} else {
 26+ // wfDebug( "Warning: no dba extension found, using emulation.\n" );
2727 return new CdbReader_PHP( $fileName );
28 - }
 28+ //}
2929 }
3030
3131 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r1134111.19wmf1: MFT r105964, r106137catrope22:08, 8 March 2012

Status & tagging log