r104886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104885‎ | r104886 | r104887 >
Date:19:09, 1 December 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
dont need this since Special pages arent server-cached anyway
Modified paths:
  • /trunk/extensions/FundraiserLandingPage/FundraiserRedirector.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FundraiserLandingPage/FundraiserRedirector.body.php
——@@ -14,7 +14,6 @@
1515 function execute( $par ) {
1616 global $wgRequest, $wgOut, $wgFundraiserLPDefaults;
1717
18 - $wgOut->setSquidMaxage( 0 ); // Never cache on server side
1918 $this->setHeaders();
2019
2120 // Set the country parameter

Follow-up revisions

RevisionCommit summaryAuthorDate
r105237follow-up to r104886, dont need headers since were redirecting anywaykaldari22:21, 5 December 2011
r105248MFT r104829, r104886, r104942, r104984, r105001, r105124, r105237awjrichards23:36, 5 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104829adding a redirector and fixing old code to use globalskaldari02:51, 1 December 2011

Comments

#Comment by Awjrichards (talk | contribs)   22:12, 5 December 2011

I don't think you need 

$this->setHeaders();

either.

#Comment by Kaldari (talk | contribs)   22:21, 5 December 2011

Ah, good point. Removed in r105237.

Status & tagging log