r104887 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104886‎ | r104887 | r104888 >
Date:19:11, 1 December 2011
Author:gicode
Status:ok (Comments)
Tags:
Comment:
Attempt to fix External Edit for files.

I would feel better if I knew how to test this all the way through...

Follow-up r102521.
Modified paths:
  • /trunk/phase3/includes/ExternalEdit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalEdit.php
——@@ -80,7 +80,7 @@
8181 } else {
8282 if ( $this->getRequest()->getVal( 'mode' ) == 'file' ) {
8383 $type = "Edit file";
84 - $image = wfLocalFile( $this->title );
 84+ $image = wfLocalFile( $this->getTitle() );
8585 $urls = array( 'File' => array(
8686 'Extension' => $image->getExtension(),
8787 'URL' => $image->getCanonicalURL()

Sign-offs

UserFlagDate
Brion Testaccounttested22:22, 1 December 2011
Brion VIBBERtested22:22, 1 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102521Some updates to EditPage and ExternalEdit:...ialex15:31, 9 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:23, 1 December 2011

I tested editing an SVG file locally using this on my trunk wiki, using Manual:External editors#XExternalEdit as an assist (to load the file into the Gnome image viewer, and then Inkscape from there, and then to upload it back when done). Seems to work!

Status & tagging log