r104984 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104983‎ | r104984 | r104985 >
Date:18:10, 2 December 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r104829 - better way to build URL
Modified paths:
  • /trunk/extensions/FundraiserLandingPage/FundraiserRedirector.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FundraiserLandingPage/FundraiserRedirector.body.php
@@ -32,14 +32,14 @@
3333 $country = $wgFundraiserLPDefaults[ 'country' ];
3434 }
3535
36 - $params = "country=$country";
 36+ $params = array( 'country' => $country );
3737
3838 // Pass any other params that are set
3939 $excludeKeys = array( 'country', 'title' );
4040 foreach ( $wgRequest->getValues() as $key => $value ) {
4141 // Skip the required variables
4242 if ( !in_array( $key, $excludeKeys ) ) {
43 - $params .= '&'."$key=$value";
 43+ $params[$key] = $value;
4444 }
4545 }
4646

Follow-up revisions

RevisionCommit summaryAuthorDate
r105248MFT r104829, r104886, r104942, r104984, r105001, r105124, r105237awjrichards23:36, 5 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104829adding a redirector and fixing old code to use globalskaldari02:51, 1 December 2011

Status & tagging log