r104867 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104866‎ | r104867 | r104868 >
Date:16:24, 1 December 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
apply patch from Bug 32501 - [QuestyCaptcha] Help page is broken

Fixes:

When trying to open the help page, the following messages appear:
<pre>
Notice: Undefined property: QuestyCaptcha::$storage in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68

Fatal error: Call to a member function cookiesNeeded() on a non-object in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68
</pre>

Might need to be merged so Extension Distributor can use it?
Modified paths:
  • /trunk/extensions/ConfirmEdit/QuestyCaptcha.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/QuestyCaptcha.class.php
——@@ -65,7 +65,7 @@
6666 global $wgOut;
6767 $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
6868 $wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
69 - if ( $this->storage->cookiesNeeded() ) {
 69+ if ( CaptchaStore::get()->cookiesNeeded() ) {
7070 $wgOut->addWikiText( wfMsg( 'captchahelp-cookies-needed' ) );
7171 }
7272 }

Sign-offs

UserFlagDate
Nikerabbitinspected17:32, 12 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r107929MFT r104622, r104867, r107120, r107337reedy19:34, 3 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   16:31, 4 December 2011

Needs to be merged with the 1.18 branch

Status & tagging log