r107929 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107928‎ | r107929 | r107930 >
Date:19:34, 3 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/ConfirmEdit/FancyCaptcha.class.php (modified) (history)
  • /branches/REL1_18/extensions/ConfirmEdit/QuestyCaptcha.class.php (modified) (history)
  • /branches/REL1_18/extensions/UserDailyContribs/UserDailyContribs.php (modified) (history)
  • /branches/REL1_18/extensions/UserDailyContribs/api/ApiUserDailyContribs.php (modified) (history)
  • /branches/REL1_18/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/ConfirmEdit/QuestyCaptcha.class.php
@@ -64,7 +64,7 @@
6565 global $wgOut;
6666 $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
6767 $wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
68 - if ( $this->storage->cookiesNeeded() ) {
 68+ if ( CaptchaStore::get()->cookiesNeeded() ) {
6969 $wgOut->addWikiText( wfMsg( 'captchahelp-cookies-needed' ) );
7070 }
7171 }
Index: branches/REL1_18/extensions/ConfirmEdit/FancyCaptcha.class.php
@@ -72,6 +72,9 @@
7373 Xml::element( 'input', array(
7474 'name' => 'wpCaptchaWord',
7575 'id' => 'wpCaptchaWord',
 76+ 'autocorrect' => 'off',
 77+ 'autocapitalize' => 'off',
 78+ 'required',
7679 'tabindex' => 1 ) ) . // tab in before the edit textarea
7780 "</p>\n";
7881 }
Index: branches/REL1_18/extensions/UserDailyContribs/api/ApiUserDailyContribs.php
@@ -10,6 +10,7 @@
1111 $days = $params['daysago'];
1212 $user = User::newFromName($userName);
1313 if ( !$user ) {
 14+ if ( !$wgAuth->userExists( $userName ) ) {
1415 $this->dieUsage( 'Specified user does not exist', 'bad_user' );
1516 }
1617
Index: branches/REL1_18/extensions/UserDailyContribs/UserDailyContribs.php
@@ -32,6 +32,16 @@
3333 $wgAPIModules['userdailycontribs'] = 'ApiUserDailyContribs';
3434
3535 /**
 36+ * Whether or not API calls should require
 37+ * that the given user name exists in whatever authentication
 38+ * is set up in $wgAuth. Note that by default, on a plain install
 39+ * there is no authentication plugin, hence all checks for existance
 40+ * return to false.
 41+ * If you use CentralAuth you'd probably want to set this to true.
 42+ */
 43+$wgUserDailyContributionsApiCheckAuthPlugin = false;
 44+
 45+/**
3646 * Get the number of revisions a user has made since a given time
3747 *
3848 * @param $time beginning timestamp
Index: branches/REL1_18/extensions/WikimediaIncubator/IncubatorTest.php
@@ -654,7 +654,7 @@
655655 static function fnTestWikiLogo( &$out ) {
656656 $setLogo = self::shouldWeSetCustomLogo( $out->getTitle() );
657657 if( !$setLogo ) {
658 - return false;
 658+ return true;
659659 }
660660 global $wgLogo;
661661 $prefixForPageTitle = str_replace( '/', '-', strtolower( $setLogo['prefix'] ) );
@@ -671,7 +671,7 @@
672672 $wgLogo = $thumb->getUrl();
673673 return true;
674674 }
675 - return false;
 675+ return true;
676676 }
677677 # Use MediaWiki:Incubator-logo-wx-xx(x)
678678 $thumb = $file->transform( array( 'width' => 135, 'height' => 135 ) );
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
679679 Merged /trunk/extensions:r104621,104867,107043,107120,107337

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104622[UserDailyContribs] Add basetimestamp parameter...krinkle23:52, 29 November 2011
r104867apply patch from Bug 32501 - [QuestyCaptcha] Help page is broken...mah16:24, 1 December 2011
r107120A hook function shouldn't return false. This was causing MoodBar & WikiLove t...robin23:09, 22 December 2011
r107337* (bug 33366) ConfirmEdit: Disable autocorrect, autocapitalize on FancyCaptch...brion19:50, 26 December 2011

Status & tagging log