r104868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104867‎ | r104868 | r104869 >
Date:16:25, 1 December 2011
Author:petrb
Status:deferred
Tags:
Comment:
updated comments and minor api description fix
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.api.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -42,6 +42,9 @@
4343 return Html::element( 'img', array( 'src' => $icon, 'alt' => $mode_text ) );
4444 }
4545
 46+ /**
 47+ * @param Title $title
 48+ */
4649 public static function getAnonFromTitle( Title $title ) {
4750 return self::getAnonFromString( $title->getBaseText() );
4851 }
@@ -49,7 +52,7 @@
5053 /**
5154 * Returns the status and User element
5255 *
53 - * @param Title $title a title of page
 56+ * @param string $username a user
5457 * @return array|bool Array containing the status and User object
5558 */
5659 public static function getAnonFromString( $username ) {
@@ -77,6 +80,10 @@
7881 return array( $status, $user );
7982 }
8083
 84+ /**
 85+ * @param $title Title
 86+ * @return array
 87+ */
8188 public static function getUserInfoFromTitle( Title $title ) {
8289 return self::getUserInfoFromString( $title->getBaseText() );
8390 }
@@ -84,7 +91,7 @@
8592 /**
8693 * Returns the status and User element
8794 *
88 - * @param Title $title a title of page
 95+ * @param string $username name of user
8996 * @return array|bool Array containing the status and User object
9097 */
9198 public static function getUserInfoFromString( $username ) {
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.api.php
@@ -46,7 +46,7 @@
4747
4848 public function getParamDescription() {
4949 return array(
50 - 'user' => 'Username of user of which you want to get status',
 50+ 'user' => 'Username of user you want to get status for',
5151 );
5252 }
5353
@@ -67,6 +67,6 @@
6868 }
6969
7070 public function getVersion() {
71 - return __CLASS__ . ': $Id: OnlineStatusBar.api.php 90814 2011-12-01 15:00:00Z petrb $';
 71+ return __CLASS__ . ': $Id: OnlineStatusBar.api.php petrb $';
7272 }
7373 }

Status & tagging log