r104160 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104159‎ | r104160 | r104161 >
Date:12:18, 24 November 2011
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r99389: Lower diacritics are invisible in titles in Indic languages Assamese, Bengali and Odiya.
Add bug numbers and issue description to release notes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -797,20 +797,38 @@
798798
799799 /* Language specific height correction for titles. Ref Bug 29405 and Bug 30809 */
800800 /* Languages like hi or ml require slightly more vertical space to show diacritics properly */
 801+h1:lang(as),
 802+h1:lang(bn),
801803 h1:lang(hi),
802 -h1:lang(ml) {
 804+h1:lang(ml),
 805+h1:lang(or) {
803806 line-height: 1.5em;
804807 }
 808+h2:lang(as),
 809+h2:lang(bn),
805810 h2:lang(hi),
806811 h2:lang(ml),
 812+h2:lang(or),
 813+h3:lang(as),
 814+h3:lang(bn),
807815 h3:lang(hi),
808816 h3:lang(ml),
 817+h3:lang(or),
 818+h4:lang(as),
 819+h4:lang(bn),
809820 h4:lang(hi),
810821 h4:lang(ml),
 822+h4:lang(or),
 823+h5:lang(as),
 824+h5:lang(bn),
811825 h5:lang(hi),
812826 h5:lang(ml),
 827+h5:lang(or),
 828+h6:lang(as),
 829+h6:lang(bn),
813830 h6:lang(hi),
814 -h6:lang(ml) {
 831+h6:lang(ml),
 832+h6:lang(or) {
815833 line-height: 1.2em;
816834 }
817835
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -191,6 +191,8 @@
192192 * (bug 31193) Set fallback language of Assamese from Bengali to English.
193193 * Update date format for dsb and hsb: month names need the genitive.
194194 * (bug 28643) Serbian variant conversion improvements (Nikola Smolenski).
 195+* (bug 29405, bug 30809) Lower diacritics are invisible in titles in Indic
 196+ languages Assamese, Bengali, Hindi, Malyalam and Odiya.
195197
196198 === Other changes in 1.19 ===
197199 * jquery.mwPrototypes module was renamed to jquery.mwExtension.

Follow-up revisions

RevisionCommit summaryAuthorDate
r105517Fix the line heights for Indic languages. Refer Bug 32826....santhosh06:19, 8 December 2011
r105914MFT r104160 r105517 r105521 r100441 r105227nikerabbit18:48, 12 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99389Language specific height correction for titles. Ref Bug 29405 and Bug 30809. ...santhosh04:13, 10 October 2011

Status & tagging log