r104159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104158‎ | r104159 | r104160 >
Date:12:09, 24 November 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
Limit the Narayam menu height so that it doesn't overflow the screen - had to increase padding to accommodate the scrollbars.
Modified paths:
  • /trunk/extensions/Narayam/resources/ext.narayam.core.css (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/resources/ext.narayam.core.css
——@@ -78,10 +78,12 @@
7979 list-style: none;
8080 list-style-image: none;
8181 list-style-type: none;
82 - padding: 0;
 82+ padding: 10px; /* Space for scrollbars etc. */
8383 margin: 0;
8484 margin-left: -1px;
8585 text-align: left;
 86+ max-height: 360px;
 87+ overflow-y: auto;
8688 }
8789 /* Fixes old versions of FireFox */
8890 div#narayam-menu ul,

Follow-up revisions

RevisionCommit summaryAuthorDate
r105281Fix Narayam for monobook skin(Bug 32124)...santhosh10:02, 6 December 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   18:37, 24 November 2011

In IE 8, I see that the menu width is reduced and a horizontal scrollbar appearing.

#Comment by Nikerabbit (talk | contribs)   18:44, 24 November 2011

10px is not enough for scrollbars in IE?

#Comment by Brion VIBBER (talk | contribs)   18:47, 24 November 2011

More like 16-20px probably.

#Comment by Nikerabbit (talk | contribs)   08:13, 25 November 2011

IE7 and 8 are just broken. Need to revert or make special fix for them.

#Comment by Santhosh.thottingal (talk | contribs)   10:53, 7 December 2011

r105281 fixed the IE scroll issue.

Status & tagging log