r105517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105516‎ | r105517 | r105518 >
Date:06:19, 8 December 2011
Author:santhosh
Status:resolved (Comments)
Tags:
Comment:
Fix the line heights for Indic languages. Refer Bug 32826.
Grouped the elements based on language.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -799,36 +799,30 @@
800800 /* Languages like hi or ml require slightly more vertical space to show diacritics properly */
801801 h1:lang(as),
802802 h1:lang(bn),
 803+h1:lang(gu),
803804 h1:lang(hi),
 805+h1:lang(kn),
804806 h1:lang(ml),
805 -h1:lang(or) {
 807+h1:lang(mr),
 808+h1:lang(or),
 809+h1:lang(pa),
 810+h1:lang(sa),
 811+h1:lang(ta),
 812+h1:lang(te) {
806813 line-height: 1.5em;
807814 }
808 -h2:lang(as),
809 -h2:lang(bn),
810 -h2:lang(hi),
811 -h2:lang(ml),
812 -h2:lang(or),
813 -h3:lang(as),
814 -h3:lang(bn),
815 -h3:lang(hi),
816 -h3:lang(ml),
817 -h3:lang(or),
818 -h4:lang(as),
819 -h4:lang(bn),
820 -h4:lang(hi),
821 -h4:lang(ml),
822 -h4:lang(or),
823 -h5:lang(as),
824 -h5:lang(bn),
825 -h5:lang(hi),
826 -h5:lang(ml),
827 -h5:lang(or),
828 -h6:lang(as),
829 -h6:lang(bn),
830 -h6:lang(hi),
831 -h6:lang(ml),
832 -h6:lang(or) {
 815+h2, h3, h4, h5, h6 [lang=as],
 816+h2, h3, h4, h5, h6 [lang=bn],
 817+h2, h3, h4, h5, h6 [lang=gu],
 818+h2, h3, h4, h5, h6 [lang=hi],
 819+h2, h3, h4, h5, h6 [lang=kn],
 820+h2, h3, h4, h5, h6 [lang=ml],
 821+h2, h3, h4, h5, h6 [lang=mr],
 822+h2, h3, h4, h5, h6 [lang=or],
 823+h2, h3, h4, h5, h6 [lang=pa],
 824+h2, h3, h4, h5, h6 [lang=sa],
 825+h2, h3, h4, h5, h6 [lang=ta],
 826+h2, h3, h4, h5, h6 [lang=te] {
833827 line-height: 1.2em;
834828 }
835829
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -212,6 +212,7 @@
213213 * (bug 28643) Serbian variant conversion improvements (Nikola Smolenski).
214214 * (bug 29405, bug 30809) Lower diacritics are invisible in titles in Indic
215215 languages Assamese, Bengali, Hindi, Malyalam and Odiya.
 216+* (bug 32826) Titles in indic languages are partially cut.
216217
217218 === Other changes in 1.19 ===
218219 * jquery.mwPrototypes module was renamed to jquery.mwExtension.

Follow-up revisions

RevisionCommit summaryAuthorDate
r105521Follow up r105517. Corrected the CSS.santhosh08:29, 8 December 2011
r105914MFT r104160 r105517 r105521 r100441 r105227nikerabbit18:48, 12 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104160Follow-up r99389: Lower diacritics are invisible in titles in Indic languages...siebrand12:18, 24 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:32, 8 December 2011

I don't think that syntax actually works as intented. As far as I can see it matches any h2, h3... in any language.

Status & tagging log