r104098 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104097‎ | r104098 | r104099 >
Date:23:06, 23 November 2011
Author:khorn
Status:ok
Tags:
Comment:
Dumb error of mine from r102332 - setWMFStatus should always be set to one of the five accepted values.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -1176,7 +1176,7 @@
11771177 //we didn't do the check, because we're going to fail the thing.
11781178 $final = $this->do_transaction( 'CANCEL_PAYMENT' );
11791179 if ( isset( $final['status'] ) && $final['status'] === true ) {
1180 - $this->setTransactionWMFStatus( $order_status_results );
 1180+ $this->setTransactionWMFStatus( 'failed' );
11811181 $this->unsetAllSessionData();
11821182 } else {
11831183 $problemflag = true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r104100MFT r104098khorn23:18, 23 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102332Fixes the following issue:...khorn21:59, 7 November 2011

Status & tagging log