r104099 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104098‎ | r104099 | r104100 >
Date:23:17, 23 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Made class replacement catch spaces too, so we don't keep adding more and more spaces each time we update the class of a heading
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.HeadingView.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/views/es.ListItemView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.ListItemView.js
@@ -33,8 +33,8 @@
3434 .attr(
3535 'class',
3636 classes
37 - .replace( /es-listItemView-level[0-9]+/, '' )
38 - .replace( /es-listItemView-(bullet|number)/, '' )
 37+ .replace( / ?es-listItemView-level[0-9]+/, '' )
 38+ .replace( / ?es-listItemView-(bullet|number)/, '' )
3939 )
4040 // Set the list style class from the style on top of the stack
4141 .addClass( 'es-listItemView-' + styles[styles.length - 1] )
Index: trunk/extensions/VisualEditor/modules/es/views/es.HeadingView.js
@@ -27,7 +27,7 @@
2828 level = this.model.getElementAttribute( 'level' );
2929 this.$
3030 // Remove any existing level classes
31 - .attr( 'class', classes.replace( /es-headingView-level[0-9]+/, '' ) )
 31+ .attr( 'class', classes.replace( / ?es-headingView-level[0-9]+/, '' ) )
3232 // Add a new level class
3333 .addClass( 'es-headingView-level' + level );
3434 };

Status & tagging log