r104097 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r104096
|
r104097
|
r104098
>
Date:
22:46, 23 November 2011
Author:
ashley
Status:
ok
Tags:
Comment:
SocialProfile: partially revert
r102178
-- turns out that this code is bad copypasta, user_board's columns are prefixed with ub, not ug, and there is no ub_status column at all...
Modified paths:
/trunk/extensions/SocialProfile/UserBoard/UserBoardClass.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/SocialProfile/UserBoard/UserBoardClass.php
—
—
@@ -148,6 +148,7 @@
149
149
150
150
$key = wfMemcKey( 'user', 'newboardmessage', $user_id );
151
151
$newCount = 0;
152
+ /*
152
153
$dbw = wfGetDB( DB_MASTER );
153
154
$s = $dbw->selectRow(
154
155
'user_board',
—
—
@@ -158,6 +159,7 @@
159
160
if ( $s !== false ) {
160
161
$newCount = $s->count;
161
162
}
163
+ */
162
164
163
165
$wgMemc->set( $key, $newCount );
164
166
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r102178
SocialProfile: as per Markus' in-depth review:...
ashley
15:06, 6 November 2011
Status & tagging log
09:09, 18 January 2012
Siebrand
(
talk
|
contribs
)
changed the
tags
for r104097
[
removed:
socialprofile]
17:42, 16 January 2012
😂
(
talk
|
contribs
)
changed the
status
of r104097
[
removed:
new
added:
ok]
14:24, 15 January 2012
Jack Phoenix
(
talk
|
contribs
)
changed the
status
of r104097
[
removed:
deferred
added:
new]
16:38, 6 January 2012
Reedy
(
talk
|
contribs
)
changed the
status
of r104097
[
removed:
new
added:
deferred]
06:16, 5 January 2012
RobLa-WMF
(
talk
|
contribs
)
changed the
tags
for r104097
[
added:
socialprofile]
10:48, 11 December 2011
Jack Phoenix
(
talk
|
contribs
)
changed the
status
of r104097
[
removed:
deferred
added:
new]
09:33, 8 December 2011
Tim Starling
(
talk
|
contribs
)
changed the
status
of r104097
[
removed:
new
added:
deferred]