r104079 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104078‎ | r104079 | r104080 >
Date:20:09, 23 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.18wmf1: MFT r92758
Modified paths:
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.localize.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/resources/jquery/jquery.localize.js
@@ -37,7 +37,12 @@
3838 return mw.msg.apply( mw, args );
3939 };
4040 return $(this)
41 - .find( 'html\\:msg' )
 41+ // Ok, so here's the story on this selector.
 42+ // In IE 6/7, searching for 'msg' turns up the 'html:msg', but searching for 'html:msg' does not.
 43+ // In later IE and other browsers, searching for 'html:msg' turns up the 'html:msg', but searching for 'msg' does not.
 44+ // So searching for both 'msg' and 'html:msg' seems to get the job done.
 45+ // This feels pretty icky, though.
 46+ .find( 'msg,html\\:msg' )
4247 .each( function() {
4348 var $el = $(this);
4449 $el

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92758Followup r92329: Fixes the localize test cases in IE 6 and 7....brion17:45, 21 July 2011

Comments

#Comment by Krinkle (talk | contribs)   22:13, 23 November 2011

Looks like trunk and 1.18wmf1 are now completely in sync on this file.

Status & tagging log