r92758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92757‎ | r92758 | r92759 >
Date:17:45, 21 July 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Followup r92329: Fixes the localize test cases in IE 6 and 7.

Looks like we do in fact need to select on 'msg,html\\:msg' in order to find the <html:msg> bits on both IE 6/7 (search for 'msg') and everything-else (search for 'html:msg').
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.localize.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.localize.js
@@ -37,7 +37,12 @@
3838 return mw.msg.apply( mw, args );
3939 };
4040 return $(this)
41 - .find( 'html\\:msg' )
 41+ // Ok, so here's the story on this selector.
 42+ // In IE 6/7, searching for 'msg' turns up the 'html:msg', but searching for 'html:msg' does not.
 43+ // In later IE and other browsers, searching for 'html:msg' turns up the 'html:msg', but searching for 'msg' does not.
 44+ // So searching for both 'msg' and 'html:msg' seems to get the job done.
 45+ // This feels pretty icky, though.
 46+ .find( 'msg,html\\:msg' )
4247 .each( function() {
4348 var $el = $(this);
4449 $el

Follow-up revisions

RevisionCommit summaryAuthorDate
r1040791.18wmf1: MFT r92758catrope20:09, 23 November 2011
r104182REL1_18 MFT r92758reedy16:30, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92329Removing deprecated <msg /> support in jquery.localize. Maintaing it is a PIT...krinkle22:54, 15 July 2011

Comments

#Comment by Krinkle (talk | contribs)   17:48, 21 July 2011

Awesome, test results here: http://toolserver.org/~krinkle/testswarm/job/237/

MarkingOK.

#Comment by Krinkle (talk | contribs)   17:43, 13 September 2011

More context on this comment and it's story at Special:Code/MediaWiki/80116#c22447.

#Comment by G.Hagedorn (talk | contribs)   21:40, 23 November 2011

Deployed to 1.18wmf1, please consider tagging for 1.18, for IE 6 and 7 compatibility

#Comment by Krinkle (talk | contribs)   22:37, 23 November 2011

Hereby tagged. Other commits that are required for this commit to make sense were already merged as well.

Status & tagging log