r104078 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104077‎ | r104078 | r104079 >
Date:20:06, 23 November 2011
Author:rmoen
Status:ok (Comments)
Tags:
Comment:
Fix small javascript errors
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -122,7 +122,7 @@
123123 .removeClass( 'mw-moodBar-selected' )
124124 .removeClass( 'mw-moodBar-happy-selected' )
125125 .removeClass( 'mw-moodBar-sad-selected' )
126 - .removeClass( 'mw-moodBar-confused-selected' );
 126+ .removeClass( 'mw-moodBar-confused-selected' );
127127 mb.validate();
128128 } )
129129 .get( 0 )
@@ -155,7 +155,7 @@
156156 $el.slideDown( 'fast' );
157157 $trigger.html( mw.msg( 'moodbar-what-expanded' ) );
158158 }
159 - } )
 159+ } );
160160 } )
161161 .end()
162162 .find( '.mw-moodBar-overlayWhatContent' )
@@ -177,7 +177,7 @@
178178 new mw.html.Raw( out )
179179 );
180180
181 - disableMsg = mw.msg( 'moodbar-disable-link' )
 181+ disableMsg = mw.msg( 'moodbar-disable-link' );
182182 disableLink = mw.html.element( 'a', {
183183 'href' : '#',
184184 'class' : 'mw-moodBar-disable'
@@ -281,7 +281,7 @@
282282 newWidth = titleWidth;
283283 }
284284
285 - mb.ui.overlay.width(newWidth);
 285+ mb.ui.overlay.width(newWidth);
286286 mb.ui.overlay.hide();
287287
288288 // Bind triger
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -77,7 +77,7 @@
7878 .end()
7979 .append( $( '<span>' ).text( text ) );
8080 }
81 -
 81+
8282 /**
8383 * Load a set of 20 comments into the list. In 'filter' mode, the list is
8484 * blanked before the new comments are loaded. In 'more' mode, the comments are
@@ -139,7 +139,7 @@
140140 return;
141141 }
142142
143 - var comments = data.query.moodbarcomments,
 143+ var comments = data.query.moodbarcomments,
144144 len = comments.length,
145145 $ul = $( '#fbd-list' ),
146146 moreResults = false,

Comments

#Comment by Catrope (talk | contribs)   20:08, 23 November 2011
-				var 	comments = data.query.moodbarcomments,
+				var comments = data.query.moodbarcomments,

You're actually undoing proper coding style here. OK otherwise, marking OK.

#Comment by Robmoen (talk | contribs)   21:57, 23 November 2011

oops. JSlint was being fussy about it, so I changed.

Status & tagging log