r103038 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103037‎ | r103038 | r103039 >
Date:21:42, 14 November 2011
Author:jamesur
Status:ok
Tags:
Comment:
adjust rtbt-sofo to fix some visual issues and take out GB from main form. Adjust GB form to be anonymous as well
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html
@@ -64,27 +64,22 @@
6565 <div id="billing-content" class="gainlayout">
6666 <div id="billingErrorMessages" class="small"></div>
6767 <div id="paymentErrorMessages" class="small"></div>
68 - <div class="name-fields">
69 - <span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>
70 - <span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>
71 - </div>
 68+ <!--<div class="name-fields">-->
 69+ <!--<span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>-->
 70+ <!--<span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>-->
 71+ <!--</div>-->
7272 <div class="loc-fields nostate">
73 - <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
74 - <span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>
75 - <span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>
 73+ <!--<span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>-->
 74+ <!--<span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>-->
 75+ <!--<span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>-->
7676 <span class="loc-country">
7777 <select class="txt" id="country" name="country" value="@country" placeholder="%donate_interface-country%">
7878 <option value="">%donate_interface-select-country%</option>
79 - <option value="AT">%donate_interface-country-dropdown-AT%</option>
80 - <option value="BE">%donate_interface-country-dropdown-BE%</option>
81 - <option value="DE">%donate_interface-country-dropdown-DE%</option>
82 - <option value="NL">%donate_interface-country-dropdown-NL%</option>
83 - <option value="CH">%donate_interface-country-dropdown-CH%</option>
8479 <option value="GB">%donate_interface-country-dropdown-GB%</option>
8580 </select>
8681 </span>
8782 </div>
88 - <p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>
 83+ <!--<p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>-->
8984 <table style="margin-top: 10px;" >
9085 <tr><td>
9186 <div id="bt-continue" style="margin-top: 7px;"> <input class="btn" id="bt-continueBtn" type="button" value="%donate_interface-continue%" /></div>
@@ -124,7 +119,13 @@
125120 <input type="hidden" value="rtbt" name="payment_method"/>
126121 <input type="hidden" value="rtbt_sofortuberweisung" name="payment_submethod"/>
127122 <!-- required fields omitted above -->
128 - <input type="hidden" value="XX" name="state"/>
 123+ <input type="hidden" value="John" name="fname" id="fname" />
 124+ <input type="hidden" value="Doe" name="lname" id="lname" />
 125+ <input type="hidden" value="n/a" name="street" id="street" />
 126+ <input type="hidden" value="n/a" name="city" id="city" />
 127+ <input type="hidden" value="XX" name="state" id="state" />
 128+ <input type="hidden" value="00000" name="zip" id="zip" />
 129+ <input type="hidden" value="nobody@wikimedia.org" name="emailAdd" id="emailAdd" />
129130 </form>
130131 <div id="where-content">
131132 {{LanguageSwitch|2011FR/core-appeal-whitebox-nodiv|@language}}
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html
@@ -68,7 +68,7 @@
6969 <!--<span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>-->
7070 <!--<span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>-->
7171 <!--</div>-->
72 - <div class="loc-fields nostate">
 72+ <div class="nostate">
7373 <!--<span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>-->
7474 <!--<span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>-->
7575 <!--<span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>-->
@@ -80,7 +80,6 @@
8181 <option value="DE">%donate_interface-country-dropdown-DE%</option>
8282 <option value="NL">%donate_interface-country-dropdown-NL%</option>
8383 <option value="CH">%donate_interface-country-dropdown-CH%</option>
84 - <option value="GB">%donate_interface-country-dropdown-GB%</option>
8584 </select>
8685 </span>
8786 </div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r103052MFT r102807, r102942, r102953, r102960, r102961, r102943, r103009, r103023, r...awjrichards22:17, 14 November 2011

Status & tagging log