r103009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103008‎ | r103009 | r103010 >
Date:19:30, 14 November 2011
Author:pgehres
Status:ok
Tags:
Comment:
Making IDEAL and EPS donations anonymous
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-eps.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-eps.html
@@ -59,27 +59,27 @@
6060 </tr>
6161 </table>
6262 </div>
63 - <div id="step2header"><h3>%donate_interface-billing-address% <span class="mute" id="change-billing" style="display: none;">(<a href="#">%donate_interface-change%</a>)</span></h3></div>
 63+ <div id="step2header"><h3>%donate_interface-cc-form-header-personal% <span class="mute" id="change-billing" style="display: none;">(<a href="#">%donate_interface-change%</a>)</span></h3></div>
6464 <div id="step2wrapper">
6565 <div id="billing-content" class="gainlayout">
6666 <div id="billingErrorMessages" class="small"></div>
6767 <div id="paymentErrorMessages" class="small"></div>
6868 <div class="name-fields">
69 - <span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>
70 - <span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>
 69+ <!--<span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>-->
 70+ <!--<span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>-->
7171 </div>
7272 <div class="loc-fields nostate">
73 - <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
74 - <span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>
75 - <span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>
76 - <span class="loc-country">
77 - <select class="txt" id="country" name="country" value="@country" placeholder="%donate_interface-country%">
78 - <option value="">%donate_interface-select-country%</option>
79 - <option value="AT">%donate_interface-country-dropdown-AT%</option>
80 - </select>
81 - </span>
 73+ <!--<span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>-->
 74+ <!--<span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>-->
 75+ <!--<span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>-->
 76+ <!--<span class="loc-country">-->
 77+ <!--<select class="txt" id="country" name="country" value="@country" placeholder="%donate_interface-country%">-->
 78+ <!--<option value="">%donate_interface-select-country%</option>-->
 79+ <!--<option value="AT">%donate_interface-country-dropdown-AT%</option>-->
 80+ <!--</select>-->
 81+ <!--</span>-->
8282 </div>
83 - <p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>
 83+ <!--<p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>-->
8484 <table style="margin-top: 10px;" >
8585 <tr><td>
8686 <select style="margin-top: 15px;" id="issuer_id" name="issuer_id" value="@issuer_id">
@@ -110,7 +110,6 @@
111111 <input type="hidden" value="0" name="PaypalRedirect" id="PaypalRedirect">
112112
113113 <input type="hidden" value="@amount" name="amount" />
114 - <!--<input type="hidden" value="@country" name="country" id="country" /> -->
115114 <input type="hidden" value="EUR" name="currency_code" />
116115 <input type="hidden" value="@utm_source" name="utm_source"/>
117116 <input type="hidden" value="@utm_medium" name="utm_medium"/>
@@ -133,7 +132,14 @@
134133 <input type="hidden" value="rtbt" name="payment_method"/>
135134 <input type="hidden" value="rtbt_eps" name="payment_submethod"/>
136135 <!-- required fields omitted above -->
137 - <input type="hidden" value="XX" name="state"/>
 136+ <input type="hidden" value="John" name="fname" id="fname" />
 137+ <input type="hidden" value="Doe" name="lname" id="lname" />
 138+ <input type="hidden" value="n/a" name="street" id="street" />
 139+ <input type="hidden" value="n/a" name="city" id="city" />
 140+ <input type="hidden" value="XX" name="state" id="state" />
 141+ <input type="hidden" value="AT" name="country" id="country" />
 142+ <input type="hidden" value="00000" name="zip" id="zip" />
 143+ <input type="hidden" value="nobody@wikimedia.org" name="emailAdd" id="emailAdd" />
138144 </form>
139145 <div id="where-content">
140146 {{LanguageSwitch|2011FR/core-appeal-whitebox-nodiv|@language}}
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
@@ -61,19 +61,19 @@
6262 </div>
6363
6464
65 - <div id="step2header"><h3>%donate_interface-billing-address% <span class="mute" id="change-billing" style="display: none;">(<a href="#">%donate_interface-change%</a>)</span></h3></div>
 65+ <div id="step2header"><h3>%donate_interface-cc-form-header-personal% <span class="mute" id="change-billing" style="display: none;">(<a href="#">%donate_interface-change%</a>)</span></h3></div>
6666 <div id="step2wrapper">
6767 <div id="billing-content" class="gainlayout">
6868 <div id="billingErrorMessages" class="small"></div>
6969 <div id="paymentErrorMessages" class="small"></div>
70 - <div class="name-fields">
71 - <span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>
72 - <span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>
73 - </div>
 70+ <!--<div class="name-fields">-->
 71+ <!--<span class="name-first"><input class="txt" id="fname" name="fname" title="%donate_interface-donor-fname%" value="@fname" placeholder="%donate_interface-donor-fname%"/></span>-->
 72+ <!--<span class="name-last"><input class="txt" id="lname" name="lname" title="%donate_interface-donor-lname%" value="@lname" placeholder="%donate_interface-donor-lname%"/></span>-->
 73+ <!--</div>-->
7474 <div class="loc-fields nostate">
75 - <span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>
76 - <span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>
77 - <span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>
 75+ <!--<span class="loc-street"><input class="txt" id="street" name="street" title="%donate_interface-donor-street%" value="@street" placeholder="%donate_interface-donor-street%"/></span>-->
 76+ <!--<span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-donor-postal%" value="@zip" placeholder="%donate_interface-donor-postal%"/></span>-->
 77+ <!--<span class="loc-city"><input class="txt" id="city" name="city" title="%donate_interface-donor-city%" value="@city" placeholder="%donate_interface-donor-city%"/></span>-->
7878 <!--<span class="loc-country">-->
7979 <!--<select class="txt" id="country" name="country" value="@country" placeholder="%donate_interface-country%">-->
8080 <!--<option value="">%donate_interface-select-country%</option>-->
@@ -81,7 +81,7 @@
8282 <!--</select>-->
8383 <!--</span>-->
8484 </div>
85 - <p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>
 85+ <!--<p><input class="txt" title="%donate_interface-donor-email%" id="emailAdd" name="emailAdd" value="@emailAdd" placeholder="%donate_interface-donor-email%"/> </p>-->
8686 <table style="margin-top: 10px;" >
8787 <tr><td>
8888 <select style="margin-top: 15px;" id="issuer_id" name="issuer_id" value="@issuer_id">
@@ -114,7 +114,6 @@
115115 <input type="hidden" name="returnto" value="Thank_You/en" />
116116 <input type="hidden" value="0" name="PaypalRedirect" id="PaypalRedirect">
117117 <input type="hidden" value="@amount" name="amount" />
118 - <input type="hidden" value="NL" name="country" id="country" />
119118 <input type="hidden" value="EUR" name="currency_code" />
120119 <input type="hidden" value="@utm_source" name="utm_source"/>
121120 <input type="hidden" value="@utm_medium" name="utm_medium"/>
@@ -137,7 +136,14 @@
138137 <input type="hidden" value="rtbt" name="payment_method"/>
139138 <input type="hidden" value="rtbt_ideal" name="payment_submethod"/>
140139 <!-- required fields omitted above -->
141 - <input type="hidden" value="XX" name="state"/>
 140+ <input type="hidden" value="John" name="fname" id="fname" />
 141+ <input type="hidden" value="Doe" name="lname" id="lname" />
 142+ <input type="hidden" value="n/a" name="street" id="street" />
 143+ <input type="hidden" value="n/a" name="city" id="city" />
 144+ <input type="hidden" value="XX" name="state" id="state" />
 145+ <input type="hidden" value="NL" name="country" id="country" />
 146+ <input type="hidden" value="00000" name="zip" id="zip" />
 147+ <input type="hidden" value="nobody@wikimedia.org" name="emailAdd" id="emailAdd" />
142148 </form>
143149 <div id="where-content">
144150 {{LanguageSwitch|2011FR/core-appeal-whitebox-nodiv|@language}}

Follow-up revisions

RevisionCommit summaryAuthorDate
r103052MFT r102807, r102942, r102953, r102960, r102961, r102943, r103009, r103023, r...awjrichards22:17, 14 November 2011

Status & tagging log