r102800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102799‎ | r102800 | r102801 >
Date:16:58, 11 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r102799, unconditionally running them anyway also isn't much use
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -570,10 +570,11 @@
571571 "Populating log_user_text field, printing progress markers. For large\n" .
572572 "databases, you may want to hit Ctrl-C and do this manually with\n" .
573573 "maintenance/populateLogUsertext.php.\n" );
 574+
 575+ $task = $this->maintenance->runChild( 'PopulateLogUsertext' );
 576+ $task->execute();
 577+ $this->insertUpdateRow( 'populate log_usertext' );
574578 }
575 - $task = $this->maintenance->runChild( 'PopulateLogUsertext' );
576 - $task->execute();
577 - $this->insertUpdateRow( 'populate log_usertext' );
578579 }
579580
580581 protected function doLogSearchPopulation() {
@@ -582,10 +583,11 @@
583584 "Populating log_search table, printing progress markers. For large\n" .
584585 "databases, you may want to hit Ctrl-C and do this manually with\n" .
585586 "maintenance/populateLogSearch.php.\n" );
 587+
 588+ $task = $this->maintenance->runChild( 'PopulateLogSearch' );
 589+ $task->execute();
 590+ $this->insertUpdateRow( 'populate log_search' );
586591 }
587 - $task = $this->maintenance->runChild( 'PopulateLogSearch' );
588 - $task->execute();
589 - $this->insertUpdateRow( 'populate log_search' );
590592 }
591593
592594 protected function doUpdateTranscacheField() {
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -755,10 +755,11 @@
756756 "Populating rev_parent_id fields, printing progress markers. For large\n" .
757757 "databases, you may want to hit Ctrl-C and do this manually with\n" .
758758 "maintenance/populateParentId.php.\n" );
 759+
 760+ $task = $this->maintenance->runChild( 'PopulateParentId' );
 761+ $task->execute();
 762+ $this->insertUpdateRow( 'populate rev_parent_id' );
759763 }
760 - $task = $this->maintenance->runChild( 'PopulateParentId' );
761 - $task->execute();
762 - $this->insertUpdateRow( 'populate rev_parent_id' );
763764 }
764765
765766 protected function doMaybeProfilingMemoryUpdate() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103031Reverts r102799, followsup r102800 also...reedy21:14, 14 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102799Naff all point varying on $this->updateRowExists when we never bloody insert ...reedy16:47, 11 November 2011

Status & tagging log