r102801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102800‎ | r102801 | r102802 >
Date:17:06, 11 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Same for the getPostDatabaseUpdateMaintenance

We only need to run them once
Modified paths:
  • /trunk/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/update.php
@@ -88,7 +88,7 @@
8989 $wgTitle = Title::newFromText( "MediaWiki database updater" );
9090
9191 $this->output( "MediaWiki {$wgVersion} Updater\n\n" );
92 -
 92+
9393 wfWaitForSlaves( 5 ); // let's not kill databases, shall we? ;) --tor
9494
9595 if ( !$this->hasOption( 'skip-compat-checks' ) ) {
@@ -121,8 +121,12 @@
122122 $updater->doUpdates( $updates );
123123
124124 foreach( $updater->getPostDatabaseUpdateMaintenance() as $maint ) {
 125+ if ( $updater->updateRowExists( $maint ) ) {
 126+ continue;
 127+ }
125128 $child = $this->runChild( $maint );
126129 $child->execute();
 130+ $updater->insertUpdateRow( $maint );
127131 }
128132
129133 $this->output( "\nDone.\n" );

Comments

#Comment by 😂 (talk | contribs)   22:27, 21 November 2011

This shouldn't be necessary? LoggedUpdateMaintenance should handle this automagically.

Status & tagging log