r102799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102798‎ | r102799 | r102800 >
Date:16:47, 11 November 2011
Author:reedy
Status:reverted
Tags:
Comment:
Naff all point varying on $this->updateRowExists when we never bloody insert to that database (more of these to come as I cleanup the updater)
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -573,6 +573,7 @@
574574 }
575575 $task = $this->maintenance->runChild( 'PopulateLogUsertext' );
576576 $task->execute();
 577+ $this->insertUpdateRow( 'populate log_usertext' );
577578 }
578579
579580 protected function doLogSearchPopulation() {
@@ -584,6 +585,7 @@
585586 }
586587 $task = $this->maintenance->runChild( 'PopulateLogSearch' );
587588 $task->execute();
 589+ $this->insertUpdateRow( 'populate log_search' );
588590 }
589591
590592 protected function doUpdateTranscacheField() {
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -758,6 +758,7 @@
759759 }
760760 $task = $this->maintenance->runChild( 'PopulateParentId' );
761761 $task->execute();
 762+ $this->insertUpdateRow( 'populate rev_parent_id' );
762763 }
763764
764765 protected function doMaybeProfilingMemoryUpdate() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r102800Followup r102799, unconditionally running them anyway also isn't much usereedy16:58, 11 November 2011
r103031Reverts r102799, followsup r102800 also...reedy21:14, 14 November 2011

Status & tagging log