r102732 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102731‎ | r102732 | r102733 >
Date:01:31, 11 November 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/activemq_stomp/activemq_stomp.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/donationinterface.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/minfraud/minfraud.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/Form.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremium.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremiumUS.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_BW_Logo.bmp (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_MONO.gif (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/BPAY_Portrait_BW_Logo.bmp (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/eps-logo-long.gif (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/eps-logo-square.gif (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/iDEAL-klein.gif (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/sofortDe.png (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/sofortEn.png (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/js/lightbox1.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/lightbox1.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-enets.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-eps.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/lightbox1.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.bt.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/lightbox1.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-CA.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-US.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2stepB-US.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-CA.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-US.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/js/lightbox1.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/js/webitects_2_2stepB.js (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/Adapter/GlobalCollect/GlobalCollectTestCase.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/DonationDataTestCase.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/DonationInterfaceTestCase.php (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100644Moves the language defaulting process to DonationData's normalizeAndSanitize ...khorn20:28, 24 October 2011
r100785adding globalcollect lightboxkaldari04:17, 26 October 2011
r101785Lots going on here, in preparation for re-designing the way we validate and a...khorn04:15, 3 November 2011
r102120Fixed Sweden spelling mistake see r100823.jpostlethwaite21:08, 5 November 2011
r102318Removes all unnecessary references to 'currency', in favor of referencing 'cu...khorn20:06, 7 November 2011
r102332Fixes the following issue:...khorn21:59, 7 November 2011
r102341Added placeholder for Do bank validation error messages in $this->error_map. ...jpostlethwaite22:49, 7 November 2011
r102342Modified direct debit to properly check status. See r102341.jpostlethwaite22:53, 7 November 2011
r102345adding sofot rtbt formjamesur23:39, 7 November 2011
r102424better handling of errors by webitects globalcollect form (no more infinite s...kaldari19:12, 8 November 2011
r102425step1 doesnt exist in some versions of the form, dumping them at step2 for er...kaldari19:16, 8 November 2011
r102445Fixed spelling mistake.jpostlethwaite21:13, 8 November 2011
r102463better fallback language support for DonationInterfacekaldari23:19, 8 November 2011
r102467Enabling credit cards in TwoStepAmount form.jpostlethwaite23:52, 8 November 2011
r102468Adding support for internal messagesjpostlethwaite23:55, 8 November 2011
r102470It is unnecessary to check if the variable exists. This is done a little earl...jpostlethwaite00:31, 9 November 2011
r102476As part of the language cleanup, fixes the way we calculate the thank you and...khorn01:37, 9 November 2011
r102479Made sure everybody is getting the correctly formatted Thank You and Fail pag...khorn01:57, 9 November 2011
r102480More updates in the name of language cleanup....khorn02:21, 9 November 2011
r102549Add 2 new rtbt forms for enets (SG) and eps (AT)jamesur17:55, 9 November 2011
r102550Add BPAY logosjamesur17:59, 9 November 2011
r102580Added comment.jpostlethwaite21:52, 9 November 2011
r102590Adding B form for A/B testing in the USpgehres22:56, 9 November 2011
r102594Renaming files to remove spaces. See r102550.jpostlethwaite23:11, 9 November 2011
r102596Renaming files to remove spaces. See r102550.jpostlethwaite23:12, 9 November 2011
r102611add iDeal logojamesur01:07, 10 November 2011
r102639svn:eol-style nativeialex11:51, 10 November 2011
r102664Spaces to tabs....platonides15:53, 10 November 2011
r102698Adding rtbt-ideal and adding js for rtbt that allows for amount selection on ...pgehres22:04, 10 November 2011
r102700Switching rtbt forms to the proper appeal and header text locationspgehres22:15, 10 November 2011
r102701Fixing case sensitivity on iDEAL imagepgehres22:17, 10 November 2011
r102702add logos for sofort and epsjamesur22:19, 10 November 2011
r102703Switching payflowpro forms to the proper appeal and header text locationspgehres22:21, 10 November 2011
r102707Adding images to the other rtbt forms. Resizing eps-squarepgehres22:39, 10 November 2011
r102711Adding webitects_2_2stepB for testing against old formspgehres22:55, 10 November 2011
r102712Adding amount switching to all rtbt forms. Added GB form since they just have...pgehres23:15, 10 November 2011
r102714Fixing mime-types for BPAY images, followup r102550awjrichards23:26, 10 November 2011
r102729Handling error as an array with implodepgehres00:38, 11 November 2011

Status & tagging log