r102342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102341‎ | r102342 | r102343 >
Date:22:53, 7 November 2011
Author:jpostlethwaite
Status:ok
Tags:fundraising 
Comment:
Modified direct debit to properly check status. See r102341.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -138,10 +138,16 @@
139139
140140 $this->adapter->do_transaction( 'DO_BANKVALIDATION' );
141141
142 - if ( $this->adapter->getTransactionStatus() ) {
 142+ // Check to see if validations were successful, if so, proceed with order.
 143+ if ( in_array( $this->adapter->getTransactionWMFStatus(), $this->adapter->getGoToThankYouOn() ) ) {
143144
144145 $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
145146 }
 147+ else {
 148+
 149+ // Attach the error messages to the form
 150+ $this->adapter->setBankValidationErrors();
 151+ }
146152
147153 }
148154 else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r102732MFT r100644, r100785, r101785, r102120, r102318, r102332, r102341, r102342, r...awjrichards01:31, 11 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102341Added placeholder for Do bank validation error messages in $this->error_map. ...jpostlethwaite22:49, 7 November 2011

Status & tagging log