r102470 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102469‎ | r102470 | r102471 >
Date:00:31, 9 November 2011
Author:jpostlethwaite
Status:ok
Tags:fundraising 
Comment:
It is unnecessary to check if the variable exists. This is done a little earlier in the code. See r100074.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
——@@ -542,7 +542,7 @@
543543 } else {
544544 //return the default for that form value
545545
546 - $tempField = isset( $this->var_map[ $gateway_field_name ] ) ? $this->var_map[ $gateway_field_name ] : false;
 546+ $tempField = $this->var_map[ $gateway_field_name ];
547547
548548 $tempValue = '';
549549

Follow-up revisions

RevisionCommit summaryAuthorDate
r102732MFT r100644, r100785, r101785, r102120, r102318, r102332, r102341, r102342, r...awjrichards01:31, 11 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100074Preventing notices from unset indices in arrays.jpostlethwaite19:35, 17 October 2011

Status & tagging log