r102550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102549‎ | r102550 | r102551 >
Date:17:59, 9 November 2011
Author:jamesur
Status:ok (Comments)
Tags:
Comment:
Add BPAY logos
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/includes/BPAY+Landscape+BW+Logo.BMP (added) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/includes/BPAY+Portrait+BW+Logo.BMP (added) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_MONO.gif (added) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY Landscape BW Logo.BMP
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY Landscape BW Logo.BMP
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_MONO.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_MONO.gif
___________________________________________________________________
Added: svn:mime-type
22 + image/gif
Index: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY Portrait BW Logo.BMP
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/DonationInterface/gateway_forms/includes/BPAY Portrait BW Logo.BMP
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream

Follow-up revisions

RevisionCommit summaryAuthorDate
r102594Renaming files to remove spaces. See r102550.jpostlethwaite23:11, 9 November 2011
r102596Renaming files to remove spaces. See r102550.jpostlethwaite23:12, 9 November 2011
r102714Fixing mime-types for BPAY images, followup r102550awjrichards23:26, 10 November 2011
r102732MFT r100644, r100785, r101785, r102120, r102318, r102332, r102341, r102342, r...awjrichards01:31, 11 November 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   23:00, 9 November 2011

Do we need to worry about spaces in file names such as images?

I thought it could cause problems.

#Comment by Jpostlethwaite (talk | contribs)   23:13, 9 November 2011

I renamed the files. See follow-ups: r102594 and r102596

Status & tagging log