r102592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102591‎ | r102592 | r102593 >
Date:23:00, 9 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
1.18wmf1 MFT r100575, r101291, r101314

r101291 was merged WITHOUT the parsertest changes
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/api (modified) (history)
  • /branches/wmf/1.18wmf1/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/media (modified) (history)
  • /branches/wmf/1.18wmf1/includes/media/JpegMetadataExtractor.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/parser/CoreParserFunctions.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/api/ApiQueryWatchlist.php
@@ -410,7 +410,7 @@
411411 ' parsedcomment - Adds parsed comment of the edit',
412412 ' timestamp - Adds timestamp of the edit',
413413 ' patrol - Tags edits that are patrolled',
414 - ' size - Adds the old and new lengths of the page',
 414+ ' sizes - Adds the old and new lengths of the page',
415415 ' notificationtimestamp - Adds timestamp of when the user was last notified about the edit',
416416 ' loginfo - Adds log information where appropriate',
417417 ),
Property changes on: branches/wmf/1.18wmf1/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
418418 Merged /trunk/phase3/includes/api:r101314
Index: branches/wmf/1.18wmf1/includes/media/JpegMetadataExtractor.php
@@ -62,6 +62,10 @@
6363 }
6464
6565 $buffer = fread( $fh, 1 );
 66+ while( $buffer === "\xFF" && !feof( $fh ) ) {
 67+ // Skip through any 0xFF padding bytes.
 68+ $buffer = fread( $fh, 1 );
 69+ }
6670 if ( $buffer === "\xFE" ) {
6771
6872 // COM section -- file comment
@@ -123,9 +127,6 @@
124128 } elseif ( $buffer === "\xD9" || $buffer === "\xDA" ) {
125129 // EOI - end of image or SOS - start of scan. either way we're past any interesting segments
126130 return $segments;
127 - } elseif ( $buffer === "\xFF" ) {
128 - // Padding byte. Skip.
129 - continue;
130131 } else {
131132 // segment we don't care about, so skip
132133 $size = wfUnpack( "nint", fread( $fh, 2 ), 2 );
Property changes on: branches/wmf/1.18wmf1/includes/media
___________________________________________________________________
Modified: svn:mergeinfo
133134 Merged /trunk/phase3/includes/media:r100575,101291
Index: branches/wmf/1.18wmf1/includes/parser/CoreParserFunctions.php
@@ -98,8 +98,7 @@
9999 if ( strval( $part1 ) !== '' ) {
100100 $args = array_slice( func_get_args(), 2 );
101101 $message = wfMessage( $part1, $args )->inLanguage( $parser->getOptions()->getUserLang() )->plain();
102 - $message = $parser->replaceVariables( $message ); // like MessageCache::transform()
103 - return $message;
 102+ return array( $message, 'noparse' => false );
104103 } else {
105104 return array( 'found' => false );
106105 }
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
107106 Merged /trunk/phase3/includes:r100575,101291,101314
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
108107 Merged /trunk/phase3:r100575,101291,101314

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100575(follow up r99477) not sure what I was doing on r99477, but its not right (do...bawolff02:41, 24 October 2011
r101291Bug 31098: Template loop through MediaWiki: messages (int: function) not bein...platonides22:22, 29 October 2011
r101314(bug 32051) Fix description for wlprop=sizescatrope21:02, 30 October 2011

Comments

#Comment by Platonides (talk | contribs)   23:54, 9 November 2011

More merging problems with that file? Doing it through REL1_18 (r102544 + r102548) would have avoided it.

#Comment by Reedy (talk | contribs)   23:56, 9 November 2011

Mmm. In this case, as we're not doing unit tests against 1.18wmf1 (though, we probably should have it similarily in jenkins), so it doesn't really matter... But I could clean it up

Status & tagging log