r102455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102454‎ | r102455 | r102456 >
Date:21:55, 8 November 2011
Author:catrope
Status:ok
Tags:
Comment:
[RL2] Fix cache invalidation bug: localgadgetidsshared doesn't get purged when gadgets are added
Modified paths:
  • /branches/RL2/extensions/Gadgets/backend/LocalGadgetRepo.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/backend/LocalGadgetRepo.php
@@ -35,6 +35,12 @@
3636 return 0;
3737 }
3838
 39+ protected function updateCache( $id, $data ) {
 40+ parent::updateCache( $id, $data );
 41+ // Also purge the IDs list used by foreign repos
 42+ $wgMemc->delete( wfMemcKey( 'gadgets', 'localrepoidsshared' ) );
 43+ }
 44+
3945 protected function loadAllData() {
4046 $query = $this->getLoadAllDataQuery();
4147 $dbr = $this->getDB();

Follow-up revisions

RevisionCommit summaryAuthorDate
r102456[RL2] Followup r102455: forgot a globalcatrope21:58, 8 November 2011

Status & tagging log