r102238 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r102237‎ \| r102238 \| r102239 >
Date:	03:17, 7 November 2011
Author:	pgehres
Status:	ok
Tags:
Comment:	Localizing links and messages
Modified paths:	/trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-CA.html (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-US.html (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-CA.html (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-US.html (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-US.html
—	—	@@ -90,7 +90,7 @@
91	91
92	92
93	93	<!--<dl class="">-->
94		~~- <!--<dt><span class="label">Select credit card</span></dt>-->~~
	94	+ <!--<dt><span class="label">%donate_interface-select-credit-card%</span></dt>-->
95	95	<!--<dd class="field" style="margin-bottom: 0;">-->
96	96	<!--<ul class="options-h" id="cards" style="margin: 0;">-->
97	97	<!--<li><input id="cc-visa" name="cardtype" type="radio" value="Visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>-->
—	—	@@ -102,7 +102,7 @@
103	103	<!--</dl>-->
104	104	</div>
105	105	<!--</div>-->
106		~~- <!--<div id="step3header"><h3>Payment Information <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>-->~~
	106	+ <!--<div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>-->
107	107	<!--<div id="step3wrapper" style="display: none;">-->
108	108	<div id="payment" class="gainlayout">
109	109
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-US.html
—	—	@@ -89,7 +89,7 @@
90	90
91	91
92	92	<dl class="">
93		~~- <dt><span class="label">Select credit card</span></dt>~~
	93	+ <dt><span class="label">%donate_interface-select-credit-card%</span></dt>
94	94	<dd class="field" style="margin-bottom: 0;">
95	95	<ul class="options-h" id="cards" style="margin: 0;">
96	96	<li><input id="cc-visa" name="cardtype" type="radio" value="Visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>
—	—	@@ -102,7 +102,7 @@
103	103	</dl>
104	104	</div>
105	105	</div>
106		~~- <div id="step3header"><h3>Payment Information <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>~~
	106	+ <div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>
107	107	<div id="step3wrapper" style="display: none;">
108	108	<div id="payment" class="gainlayout">
109	109	<div id="paymentErrorMessages" class="small"></div>
—	—	@@ -197,13 +197,19 @@
198	198	</div>
199	199	</div>
200	200	<p id="informationsharing">%donate_interface-informationsharing%</p>
201		~~- <!-- TODO: links inside the message or not? -->~~
202		~~- <ul id="moreinfolinks">~~
203		~~- <li><a href="http://wikimediafoundation.org/wiki/Monthly_donations/en/US">%donate_interface-monthly-donation%</a></li><!-- TODO: localize the link -->~~
204		~~- <li>%donate_interface-otherways-short%</li><!-- TODO: localize the link -->~~
205		~~- <li><a href="http://wikimediafoundation.org/wiki/FAQ/en">%donate_interface-faqs%</a></li><!-- TODO: localize the link -->~~
206		~~- <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->~~
207		~~- </ul>~~
	201	+ <table>
	202	+ <tr>
	203	+ <td>
	204	+ <ul id="moreinfolinks">
	205	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Monthly_donations&language=@language&uselang=@language&country=@country">%donate_interface-monthly-donation%</a></li>
	206	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Ways_to_Give&language=@language&uselang=@language&country=@country">%donate_interface-otherways-short%</a></li>
	207	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=FAQ&language=@language&uselang=@language&country=@country">%donate_interface-faqs%</a></li>
	208	+ <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->
	209	+ </ul>
	210	+ </td>
	211	+ <td>@verisign_logo</td>
	212	+ </tr>
	213	+ </table>
208	214	</div>
209	215	</td>
210	216	</tr>
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_2step-CA.html
—	—	@@ -90,7 +90,7 @@
91	91
92	92
93	93	<!--<dl class="">-->
94		~~- <!--<dt><span class="label">Select credit card</span></dt>-->~~
	94	+ <!--<dt><span class="label">%donate_interface-select-credit-card%</span></dt>-->
95	95	<!--<dd class="field" style="margin-bottom: 0;">-->
96	96	<!--<ul class="options-h" id="cards" style="margin: 0;">-->
97	97	<!--<li><input id="cc-visa" name="cardtype" type="radio" value="Visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>-->
—	—	@@ -102,7 +102,7 @@
103	103	<!--</dl>-->
104	104	</div>
105	105	<!--</div>-->
106		~~- <!--<div id="step3header"><h3>Payment Information <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>-->~~
	106	+ <!--<div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>-->
107	107	<!--<div id="step3wrapper" style="display: none;">-->
108	108	<div id="payment" class="gainlayout">
109	109
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step.html
—	—	@@ -86,7 +86,7 @@
87	87	<span class="loc-postal"><input class="txt" id="zip" name="zip" title="%donate_interface-zip%" value="@zip" placeholder="%donate_interface-donor-zip%"/></span> <!-- TODO: use postal code on non-US -->
88	88	<span class="loc-country">
89	89	<select class="txt" id="country" name="country" value="@country" placeholder="%donate_interface-country%">
90		~~- <option value="">Select a country</option>~~
	90	+ <option value="">%donate_interface-select-country%</option>
91	91	<option value="AF">%donate_interface-country-dropdown-AF%</option><option value="AL">%donate_interface-country-dropdown-AL%</option><option value="DZ">%donate_interface-country-dropdown-DZ%</option><option value="AS">%donate_interface-country-dropdown-AS%</option><option value="AD">%donate_interface-country-dropdown-AD%</option><option value="AO">%donate_interface-country-dropdown-AO%</option><option value="AI">%donate_interface-country-dropdown-AI%</option><option value="AQ">%donate_interface-country-dropdown-AQ%</option><option value="AG">%donate_interface-country-dropdown-AG%</option><option value="AR">%donate_interface-country-dropdown-AR%</option><option value="AM">%donate_interface-country-dropdown-AM%</option><option value="AW">%donate_interface-country-dropdown-AW%</option><option value="AU">%donate_interface-country-dropdown-AU%</option><option value="AT">%donate_interface-country-dropdown-AT%</option><option value="AZ">%donate_interface-country-dropdown-AZ%</option><option value="BS">%donate_interface-country-dropdown-BS%</option><option value="BH">%donate_interface-country-dropdown-BH%</option><option value="BD">%donate_interface-country-dropdown-BD%</option><option value="BB">%donate_interface-country-dropdown-BB%</option><option value="BY">%donate_interface-country-dropdown-BY%</option><option value="BE">%donate_interface-country-dropdown-BE%</option><option value="BZ">%donate_interface-country-dropdown-BZ%</option><option value="BJ">%donate_interface-country-dropdown-BJ%</option><option value="BM">%donate_interface-country-dropdown-BM%</option><option value="BT">%donate_interface-country-dropdown-BT%</option>
92	92	<option value="BO">%donate_interface-country-dropdown-BO%</option><option value="BA">%donate_interface-country-dropdown-BA%</option><option value="BW">%donate_interface-country-dropdown-BW%</option><option value="BV">%donate_interface-country-dropdown-BV%</option><option value="BR">%donate_interface-country-dropdown-BR%</option><option value="IN">%donate_interface-country-dropdown-IN%</option><option value="BN">%donate_interface-country-dropdown-BN%</option><option value="BG">%donate_interface-country-dropdown-BG%</option><option value="BF">%donate_interface-country-dropdown-BF%</option><option value="BI">%donate_interface-country-dropdown-BI%</option><option value="KH">%donate_interface-country-dropdown-KH%</option><option value="CM">%donate_interface-country-dropdown-CM%</option><option value="CA">%donate_interface-country-dropdown-CA%</option><option value="CV">%donate_interface-country-dropdown-CV%</option><option value="KY">%donate_interface-country-dropdown-KY%</option><option value="CF">%donate_interface-country-dropdown-CF%</option><option value="TD">%donate_interface-country-dropdown-TD%</option><option value="CL">%donate_interface-country-dropdown-CL%</option><option value="CN">%donate_interface-country-dropdown-CN%</option><option value="CX">%donate_interface-country-dropdown-CX%</option><option value="CC">%donate_interface-country-dropdown-CC%</option><option value="CO">%donate_interface-country-dropdown-CO%</option><option value="KM">%donate_interface-country-dropdown-KM%</option><option value="CG">%donate_interface-country-dropdown-CG%</option><option value="CD">%donate_interface-country-dropdown-CD%</option>
93	93	<option value="CK">%donate_interface-country-dropdown-CK%</option><option value="CR">%donate_interface-country-dropdown-CR%</option><option value="HR">%donate_interface-country-dropdown-HR%</option><option value="CY">%donate_interface-country-dropdown-CY%</option><option value="CZ">%donate_interface-country-dropdown-CZ%</option><option value="CI">%donate_interface-country-dropdown-CI%</option><option value="DK">%donate_interface-country-dropdown-DK%</option><option value="DJ">%donate_interface-country-dropdown-DJ%</option><option value="DM">%donate_interface-country-dropdown-DM%</option><option value="DO">%donate_interface-country-dropdown-DO%</option><option value="EC">%donate_interface-country-dropdown-EC%</option><option value="EG">%donate_interface-country-dropdown-EG%</option><option value="SV">%donate_interface-country-dropdown-SV%</option><option value="GQ">%donate_interface-country-dropdown-GQ%</option><option value="ER">%donate_interface-country-dropdown-ER%</option><option value="EE">%donate_interface-country-dropdown-EE%</option><option value="ET">%donate_interface-country-dropdown-ET%</option><option value="FK">%donate_interface-country-dropdown-FK%</option><option value="FO">%donate_interface-country-dropdown-FO%</option><option value="FJ">%donate_interface-country-dropdown-FJ%</option><option value="FI">%donate_interface-country-dropdown-FI%</option><option value="FR">%donate_interface-country-dropdown-FR%</option><option value="GF">%donate_interface-country-dropdown-GF%</option><option value="PF">%donate_interface-country-dropdown-PF%</option><option value="TF">%donate_interface-country-dropdown-TF%</option>
—	—	@@ -104,7 +104,7 @@
105	105
106	106
107	107	<dl class="">
108		~~- <dt><span class="label">Select credit card</span></dt>~~
	108	+ <dt><span class="label">%donate_interface-select-credit-card%</span></dt>
109	109	<dd class="field" style="margin-bottom: 0;">
110	110	<ul class="options-h" id="cards" style="margin: 0;">
111	111	<li><input id="cc-visa" name="cardtype" type="radio" value="Visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>
—	—	@@ -117,7 +117,7 @@
118	118	</dl>
119	119	</div>
120	120	</div>
121		~~- <div id="step3header"><h3>Payment Information <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>~~
	121	+ <div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>
122	122	<div id="step3wrapper" style="display: none;">
123	123	<div id="payment" class="gainlayout">
124	124	<div id="paymentErrorMessages" class="small"></div>
—	—	@@ -212,13 +212,19 @@
213	213	</div>
214	214	</div>
215	215	<p id="informationsharing">%donate_interface-informationsharing%</p>
216		~~- <!-- TODO: links inside the message or not? -->~~
217		~~- <ul id="moreinfolinks">~~
218		~~- <li><a href="http://wikimediafoundation.org/wiki/Monthly_donations/en/US">%donate_interface-monthly-donation%</a></li><!-- TODO: localize the link -->~~
219		~~- <li>%donate_interface-otherways-short%</li><!-- TODO: localize the link -->~~
220		~~- <li><a href="http://wikimediafoundation.org/wiki/FAQ/en">%donate_interface-faqs%</a></li><!-- TODO: localize the link -->~~
221		~~- <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->~~
222		~~- </ul>~~
	216	+ <table>
	217	+ <tr>
	218	+ <td>
	219	+ <ul id="moreinfolinks">
	220	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Monthly_donations&language=@language&uselang=@language&country=@country">%donate_interface-monthly-donation%</a></li>
	221	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Ways_to_Give&language=@language&uselang=@language&country=@country">%donate_interface-otherways-short%</a></li>
	222	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=FAQ&language=@language&uselang=@language&country=@country">%donate_interface-faqs%</a></li>
	223	+ <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->
	224	+ </ul>
	225	+ </td>
	226	+ <td>@verisign_logo</td>
	227	+ </tr>
	228	+ </table>
223	229	</div>
224	230	</td>
225	231	</tr>
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-CA.html
—	—	@@ -89,7 +89,7 @@
90	90
91	91
92	92	<dl class="">
93		~~- <dt><span class="label">Select credit card</span></dt>~~
	93	+ <dt><span class="label">%donate_interface-select-credit-card%</span></dt>
94	94	<dd class="field" style="margin-bottom: 0;">
95	95	<ul class="options-h" id="cards" style="margin: 0;">
96	96	<li><input id="cc-visa" name="cardtype" type="radio" value="Visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>
—	—	@@ -102,7 +102,7 @@
103	103	</dl>
104	104	</div>
105	105	</div>
106		~~- <div id="step3header"><h3>Payment Information <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>~~
	106	+ <div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">Change</a>)</span></h3></div>
107	107	<div id="step3wrapper" style="display: none;">
108	108	<div id="payment" class="gainlayout">
109	109	<div id="paymentErrorMessages" class="small"></div>
—	—	@@ -197,13 +197,19 @@
198	198	</div>
199	199	</div>
200	200	<p id="informationsharing">%donate_interface-informationsharing%</p>
201		~~- <!-- TODO: links inside the message or not? -->~~
202		~~- <ul id="moreinfolinks">~~
203		~~- <li><a href="http://wikimediafoundation.org/wiki/Monthly_donations/en/US">%donate_interface-monthly-donation%</a></li><!-- TODO: localize the link -->~~
204		~~- <li>%donate_interface-otherways-short%</li><!-- TODO: localize the link -->~~
205		~~- <li><a href="http://wikimediafoundation.org/wiki/FAQ/en">%donate_interface-faqs%</a></li><!-- TODO: localize the link -->~~
206		~~- <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->~~
207		~~- </ul>~~
	201	+ <table>
	202	+ <tr>
	203	+ <td>
	204	+ <ul id="moreinfolinks">
	205	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Monthly_donations&language=@language&uselang=@language&country=@country">%donate_interface-monthly-donation%</a></li>
	206	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Ways_to_Give&language=@language&uselang=@language&country=@country">%donate_interface-otherways-short%</a></li>
	207	+ <li><a href="http://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=FAQ&language=@language&uselang=@language&country=@country">%donate_interface-faqs%</a></li>
	208	+ <!--<li><a href="">%donate_interface-tax-info%</a></li>--><!-- TODO: localize the link -->
	209	+ </ul>
	210	+ </td>
	211	+ <td>@verisign_logo</td>
	212	+ </tr>
	213	+ </table>
208	214	</div>
209	215	</td>
210	216	</tr>

Follow-up revisions

Revision	Commit summary	Author	Date
r102243	MFT r102191, r102195, r102196, r102200, r102203, r102213, r102214, r102215, r...	awjrichards	03:31, 7 November 2011

Status & tagging log

03:19, 7 November 2011 Awjrichards (talk | contribs) changed the status of r102238 [removed: new added: ok]